Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

feature/qwen35 (DeltaNet) rehab checklist before it can merge

Aperta
  • Qualcosa non va?
#235 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Tranquilla
Stack tecnologico
kotlin
Ambito
backend

Direzione di ricerca

Start by reviewing the five commits on feature/qwen35, especially Qwen35Runtime.kt and Qwen35RuntimeTest.kt; the tests use a tiny synthetic model and cover the DeltaNet implementation. Then assess the checklist against current develop, including the loader rename, smoke test conflicts, engine 0.36.0, and transformer-core changes. Done means the branch is rebased, builds and passes verification against the current engine, and its diagnostic prints and conflicts are resolved.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

feature/qwen35 (5637da3, 5 commits) adds a Qwen3.5 hybrid runtime — Qwen35Runtime.kt (+637) interleaving Gated-DeltaNet (SSM) layers with full-attention layers — plus a Qwen byte-level BPE tokenizer, the Qwen3.5 chat template, and tool-call parsing. ~2,440 insertions across 20 files.

The work is genuinely valuable and shouldn't be lost. Commit 4af7e99 documents a real debugging arc, enumerating 9 specific DeltaNet bugs fixed by cross-referencing llama.cpp and the NVlabs GatedDeltaNet reference (3-way QKV split, channel-major conv1d indexing, delta-rule recurrence, softplus(alpha+dt_bias)*ssm_a decay, per-head L2 norm, Q/K head repetition 16→32, output path order, sigmoid gate). Qwen35RuntimeTest.kt (+365) covers these with 11 unit tests on a tiny synthetic model (dim=16, 4 layers, vocab=8) needing no GGUF — that test suite is the branch's real asset.

But it is not mergeable as-is. Newest commit is 2026-04-11 (~97 days old) and it sits 473 commits behind develop.

Checklist
  • Rebase from 473 behind. Merge-base is 545f06a (2026-04-21).
  • Re-verify against engine 0.36.0. The branch was written against engine 0.19.1 — 17 minor versions back. It has never been built against the current engine.
  • Strip 24 diagnostic printlns. Commit 33efe46 is explicitly titled "add init-time dimensional validation and diagnostic prints". Residue in Qwen35Runtime.kt init includes println("Qwen35Runtime: dim=$dim nHeads=$nHeads ..."), println(" ssmQkvDim=... headRatio=..."), println(" GGUF shapes: attn_qkv=$qkvShape ..."), println(" matmul convention: ..."). Some other printlns are legitimate CLI/demo output — check case by case.
  • Resolve the rename collision. The branch edits llm-inference/llama/.../LlamaWeightLoader.kt (±114); develop has renamed it to DecoderGgufWeightLoader.kt. This is a rename/edit conflict git will not resolve cleanly.
  • tests/smoke/SMOKE-TEST.md is deleted on develop — the branch modifies it (modify/delete conflict).
  • tests/smoke/smoke-models.json and llm-runtime/kllama/.../cli/Main.kt also conflict (content).
  • Also verify transformer-core interplay — the branch predates the transformer-core module entirely (added 7c8e4c8, 2026-07-03).
Notes
  • Conflict surface is small (4 conflicts, 8 overlapping files) — the risk is staleness and the engine gap, not merge mechanics.
  • Purely additive API-wise: zero removed public declarations.
  • Explicitly out of scope for 0.36.1, which ships BGE embeddings + vec2text beam search only.
Lingua principale
Kotlin
Stelle
8
Fork
3
Merge medio
1g 16h
PR unite (30g)
48

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di SKaiNET-developers/SKaiNET-transformers

Tutte le issue di SKaiNET-developers/SKaiNET-transformers

Issue simili

Altre issue su Kotlin

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.