Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[Bug] Stress period climate adjustment factors are not ingested/applied to data

Aperta
  • Qualcosa non va?
#116 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
30/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
python
Ambito
data-engineering

Direzione di ricerca

Start with reeds/core/solve/2_temporal_params.gms around lines 462-494, where cf_hyd and the climate_hydro_seasonal and watsa_climate parameters are defined, then compare with how the representative-period inputs are read. Next, look at reeds/input_processing/hourly_writetimeseries.py to see how climate_hydadjsea.csv and climate_UnappWaterSeaAnnDistr.csv are written. Done means stress-period adjustment values are read from the stress folders, so cf_hyd is no longer zero for years after GSw_ClimateStartYear.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug TODO
Summary

When running ReEDS with climate impacts to hydropower or cooling water turned ON (i.e. GSw_ClimateHydro == 1 and/or GSwClimateWater == 1), climate adjustment factors for hydropower capacity factors and unappropriated freshwater seasonal distribution factors are not being read and applied for the stress periods.

Details:

The files not being read in and applied are the versions of climate_hydadjsea.csv and climate_UnappWaterSeaAnnDistr.csv found in the stress period folders of a ReEDS run (inputs_case/stress{model_year}i{iteration}). These files contain the stress-period values of the respective data they represent, and thus, should be read in alongside the representative period versions of the file, similar to cf_hyd and other similar parameters in 2_temporal_params.gms

https://github.com/ReEDS-Model/ReEDS/blob/62e69486acf4d32321667309b0dfb6432c884f8a/reeds/core/solve/2_temporal_params.gms#L462-L494

In the above example, without stress period data in the climate_hydro_seasonal parameter, Lines 490-491 calculates the non-dispatchable stress period data in cf_hyd as 0 for all years after the GSw_ClimateStartYear designation (see screenshot of inputs.gdx below):

Image
Solution (ToDo):
  • Adjust 2_temporal_params.gms to read in both versions of the climate_{hydadjsea|UnappWaterSeaAnnDistr}.csv from the inputs/{temporal_inputs|stress}/ folders.
    • Change climate_hydro_seasonal and watsa_climate from a GAMS table to parameter (required for multi-source parameter definition)
    • Fix reeds/input_processing/hourly_writetimeseries.py to output climate_hydadjsea.csv and climate_UnappWaterSeaAnnDistr.csv in long format with * appended to front of first column name
Lingua principale
Python
Stelle
38
Fork
18
Merge medio
3g 15h
PR unite (30g)
13

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ReEDS-Model/ReEDS

Tutte le issue di ReEDS-Model/ReEDS

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.