[io] "Unicode file names on Windows can not be opened via PCD I/O"

Aperta
#6,537 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp

Direzione di ricerca

Start at PCDReader::readHeader/read and the PCDWriter::write* entry points, then follow how they open files through pcl_fs and raw_open. The issue lists every public entry point that needs a pcl_fs::path overload; keep the std::string versions forwarding and add const char* overloads to avoid ambiguity with string literals. Done means L"点群.pcd" round-trips on Windows and the existing PCD I/O tests still pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

kind: bug status: triage

Describe the bug

On Windows, PCD file names can only be passed as std::string. They reach narrow APIs: std::ifstream::open (const char*), _open, CreateFile (CreateFileA in a non-UNICODE build) and pcl_fs calls on std::string. All of them interpret the bytes in the process ANSI code page. A file whose name has characters outside that code page therefore cannot be read or written, because no std::string names it.

UTF-8 strings do not help either: they are reinterpreted as ANSI. On code page 1252, savePCDFileBinary ("\xE7\x82\xB9\xE7\xBE\xA4.pcd", cloud) (UTF-8 for 点群.pcd) creates 点群.pcd.

Applications get file names as wide strings (Qt, std::filesystem::path, Win32 dialogs). Any name outside the ANSI code page fails: CJK or emoji on a Western system, or a temporary directory under a user profile with a non-Latin user name.

Context

Read/write a PCD file with non-ANSI name, e.g. containing Japanese symbols on Windows on a non-Japanese machine.

Expected behavior

PCD files can be loaded and saved under any valid Windows file name.

Current Behavior

Only names that can be written in the ANSI code page work. Other names cannot be passed at all, and UTF-8 names refer to a different file.

To Reproduce

Try to pass, e.g., L"点群.pcd" into loadPCDFile on Windows

Your Environment (please complete the following information):

  • OS: Windows 11
  • Compiler: MSVC (Visual Studio 2026)
  • PCL Version: 1.12.1 and current master

Possible Solution

Add pcl_fs::path overloads to every file-name entry point:

  • PCDReader::readHeader, read and read<PointT>;
  • PCDWriter::write, writeASCII, writeBinary and writeBinaryCompressed;
  • loadPCDFile, savePCDFile, savePCDFileASCII, savePCDFileBinary and savePCDFileBinaryCompressed.

The path overload holds the implementation and opens by the native name. On Windows that is the wide name: std::ifstream::open (path), _wopen (path.c_str (), ...) and CreateFileW (path.c_str (), ...), plus a raw_open (const pcl_fs::path&, ...) overload, keeping _O_BINARY (see #<number of report 1>).

The existing std::string overloads forward to the path overloads, so current behaviour is unchanged. A const char* overload is also needed: with only std::string and path overloads, a call with a string literal is ambiguous, because both are user-defined conversions. The virtual std::string overloads of FileReader/FileWriter can stay and forward too.

Additional context

This issue covers PCD. The other FileReader/FileWriter formats take std::string file names too.

Lingua principale
C++
Stelle
11.2k
Fork
4.7k
Merge medio
6g 13h
PR unite (30g)
10

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di PointCloudLibrary/pcl

Tutte le issue di PointCloudLibrary/pcl

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.