Bug: `$clone` leaves `from_source_url` (and `to_source_url`) pointing at the original source on copied mappings

Aperta Adatta ai principianti
  • Qualcosa non va?
#3,012 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Ambito
backend

Direzione di ricerca

Inizia in core/sources/models.py, in clone_mappings(), e controlla come Mapping.clone() copia gli URL di origine. Confronta gli URI padre dei concetti assegnati con i valori copiati di from_source_url e to_source_url; aggiorna il percorso di clonazione affinché questi campi corrispondano ai concetti assegnati. Il lavoro è completato quando i mapping copiati con $clone restituiscono gli URL di origine di destinazione nella risposta del dettaglio/API del mapping.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

component/api decision/human-review signal/needs-access signal/quick-win signal/small-scope signal/well-specified stage/triaged type/bug

Expected Behavior

When a concept is cloned into another source with $clone, each copied mapping belongs to the target source and starts from the new concept. So its from_source_url should be the target source, e.g. /orgs/PIH/sources/PIH/. More generally, from_source_url/to_source_url should match from_concept_url/to_concept_url and from_source_name/to_source_name.

Current Behavior

from_source_url keeps the value from the original mapping, i.e. the source the concept was cloned from, while from_concept_url and from_source_name are updated.

Example: PIH 21400 was cloned from CIEL 170656. CIEL mapping /orgs/CIEL/sources/CIEL/mappings/17052749/ is SAME-AS LOINC:53625-0. The copy, https://app.v3.openconceptlab.org/orgs/PIH/sources/PIH/mappings/44946/, has:

field value
from_concept_url /orgs/PIH/sources/PIH/concepts/21400/
from_source_name PIH
from_source_url /orgs/CIEL/sources/CIEL/
to_* LOINC 53625-0 (correct)

When the clone also retargets a mapping to a concept in the target source (see #3013), to_source_url isn't updated either. Example: https://app.v3.openconceptlab.org/orgs/PIH/sources/PIH/mappings/46475/ has to_concept_url=/orgs/PIH/sources/PIH/concepts/21768/ and to_source_name=PIH, but to_source_url=/orgs/CIEL/sources/CIEL/.

The concept view labels mappings by *_source_name, so the problem is only visible in the mapping detail/edit view or the API.

Possible Solution

In core/sources/models.py clone_mappings(), the code sets from_concept_id, from_concept_code, from_source_id (and the to_* equivalents) from the assigned concepts, but not from_source_url/to_source_url. Mapping.clone() copies those URLs from the original. Setting them from the assigned concepts' parent (concept.parent.uri) would fix it.

Steps to Reproduce

  1. Pick a CIEL concept with mappings to other sources, e.g. CIEL 170656.
  2. Clone it into a source you can edit, using TermBrowser "Clone to source" (v2 or v3) or POST <target source>/concepts/$clone/ with equivalencyMapType=SAME-AS.
  3. GET the new concept with ?includeMappings=true, then GET one of its copied mappings with ?verbose=true.
  4. from_source_url is the CIEL source, not the target source.

Context (Environment)

Production (api.openconceptlab.org), PIH organization source /orgs/PIH/sources/PIH/. In release 1.8.46 about 3,850 copied mappings have this, going back to March 2024. The OpenMRS OCL module doesn't use from_source_url, so imports aren't affected, but the data is inconsistent and confusing for anyone reading or editing the mappings.

Detailed Description

Found while investigating a related, more serious clone problem: mappings to external code systems being retargeted to concepts in the target source (#3013). That issue also leaves to_source_url stale.

Lingua principale
Nessun dato sulla lingua
Stelle
4
Fork
2
Merge medio
2h 12m
PR unite (30g)
1

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenConceptLab/ocl_issues

Tutte le issue di OpenConceptLab/ocl_issues

Issue simili

Altre issue su Backend & API Design

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.