Validate US phone area-code candidates using sources with documented reuse terms

Aperta
  • Qualcosa non va?
#1,140 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
data

Direzione di ricerca

Start with data_designer/engine/sampling_gen/entities/phone_number.py and reproduce the 98933 example using PhoneNumber.from_zip_prefix; then inspect the sampler and rebuild tests and the lookup’s manifest, NOTICE, build report, and reconciliation. Identify reusable sources with documented terms and reproducible inputs, validate country, geographic use, active status, and state association, and add regression coverage for invalid or foreign codes and wrong-state associations. Done means regenerating the lookup while preserving ZIP identifiers, population weights, and valid overlay candidates without restoring NANPA-derived exclusions.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Removing NANPA-derived screening in #1139 restores erroneous Wikidata dialing-code statements to the US phone sampler. We are accepting this data-quality regression for that PR and tracking replacement validation here.

At PR commit 2a6126e0643ad4017ecd5bf78e44077c2b9e31cf:

  • ZIP 98933 always selects 590; before #1139 it selected 509.
  • Indianapolis ZIP 46201 can select unassigned 486.
  • California ZIP 95417 can select Canadian 639.

Reproduce the first example through the public sampler helper:

from data_designer.engine.sampling_gen.entities.phone_number import PhoneNumber

print(PhoneNumber.from_zip_prefix("98933"))
# The area code is always 590.

Comparison with the previously pinned screening reference found 19 newly sampleable codes that fail US/geographic/in-service checks. In total, 91 ZIPs contain a non-US, non-geographic, or out-of-service candidate, accounting for approximately 0.253% of the nationwide sampler probability. This is separate from approximate ZIP boundaries or uncertain overlay market shares.

The current 307 sampler/rebuild tests pass because they verify artifact consistency, weights, numeric shape, and selected regional examples; they do not establish numbering validity.

Expected outcome
  • Establish replacement validation for country, geographic use, active status, and state association using sources with documented reuse terms and reproducible inputs.
  • Regenerate the lookup and update its manifest, NOTICE, build report, and reconciliation.
  • Add regression coverage for invalid/foreign codes and wrong-state associations while preserving ZIP identifiers, population weights, and valid overlay candidates.
  • Keep NANPA-derived exclusions out of the replacement; copying the old list back would restore the dependency #1139 removes.

Review evidence: https://github.com/NVIDIA-NeMo/DataDesigner/pull/1139#issuecomment-6694018381

Lingua principale
Python
Stelle
2.4k
Fork
243
Merge medio
1g 3h
PR unite (30g)
88

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di NVIDIA-NeMo/DataDesigner

Tutte le issue di NVIDIA-NeMo/DataDesigner

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.