Reimplement conflation to allow on-the-fly conflation

Aperta
#224 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
python

Direzione di ricerca

Start by reading the NameRes search and CURIE lookup paths, then trace where conflation files are loaded and applied; the issue does not name specific files or tests. Implementing on-the-fly conflation spans search results, identifier lookup, and metadata, so first map those flows and their existing tests. Done means exact matches such as Tylenol’s UMLS:C0699142 remain findable and conflation can optionally expand results or report related CURIEs.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Priority: Medium Size: L

One thing that's really helped with identifying the correct clique is to (hugely) prefer preferred name exact matches over non-exact matches. One problem with conflating identifiers before putting them into NameRes is that unless we've chosen exactly right name for the overall clique, it can make it harder to find that clique and for other, non-exact matches to override it.

One way of fixing that would be to revert to our previous plan for handling conflations, which is to load the conflation files into memory and to apply conflation on-the-fly as follows:

  1. You can search NameRes without conflation turned on to get individual clique entries -- this is often what you want anyway, although you then may need to manually conflate it afterwards.
  2. You can search NameRes with conflation turned on -- we run search for the best matches and, if a match has a conflated identifier, we expand it on-the-fly to include all the other cliques in that conflation. We also add some metadata to indicate what is being conflated.
  3. If you want to look up a CURIE, we return the unconflated image, but can (optionally?) also include the list of other CURIEs that we would conflate it do under a particular conflation.

This would at least fix tylenol, which has an exact match in UMLS:C0699142, but which would then be combined into acetaminophen when conflation is applied. It might help with others, too.

Lingua principale
Python
Stelle
5
Fork
4
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di NCATSTranslator/NameResolution

Tutte le issue di NCATSTranslator/NameResolution

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.