Pin the rest of requirements.txt so a rebuild can't shift the stack silently

Aperta
#303 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Da chiarire
Stato di attività
Attiva
Stack tecnologico
fastapi, python

Direzione di ricerca

Start by reading requirements.txt and the CI and image build install steps described in the issue; compare how each environment resolves dependencies. Then decide between compatible release pins and a generated lockfile, including how updates will be scheduled. Done means both install paths use a consistent dependency set and there is a maintainable update approach.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

#294 was caused by fastapi being unpinned: the image built for v1.7.0 picked up 0.137.0, which
stopped honouring app.openapi_schema, and the service shipped a valid-but-wrong OpenAPI document
without anything failing. That pin is now fastapi~=0.141.1.

Everything else in requirements.txt is still unpinned and can move the same way under an unrelated
rebuild:

requests
httpx
uvicorn
pyyaml
jsonlines
pytest

httpx is the one that matters most — it is how the API talks to Solr — but any of them can change
between a passing CI run and the image ITRB deploys, since the two install at different times from
the same unpinned list.

Needs a decision on approach rather than a quick edit:

  • Pin everything at compatible-release (~=) versions, as fastapi and the opentelemetry packages
    now are?
  • Or generate a fully-pinned lockfile (pip-compile / uv pip compile) from a loose top-level list,
    which also makes CI and the image install identical sets?
  • Either way, how do the pins get bumped on a schedule so they don't rot into a stack we can't
    upgrade?

Related: the opentelemetry packages are already hard-pinned at 1.27.0 / 0.48b0, which is old
enough to be worth reviewing as part of this.

Lingua principale
Python
Stelle
5
Fork
4
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di NCATSTranslator/NameResolution

Tutte le issue di NCATSTranslator/NameResolution

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.