/sunset omits the deletion date, the refund offer and the MCP change
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 55/100
- Tipo di issue
- Documentazione
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- react, typescript
Direzione di ricerca
Read docs/architecture/sunset.md and journey 2 in plans/community-local/portal/02-pages.md, then inspect the STEPS array and closing section in surfsense_web/app/(home)/sunset/page.tsx. Ask a maintainer for the refund and MCP details before writing those parts; use the existing unit tests as the verification starting point. Done means the page clearly states the deletion date and maintainer-approved details, and the Known gaps line is removed.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
The gap
docs/architecture/sunset.md lists this under Known gaps:
/sunsethas the export button, download links and import steps, but not the deletion date (18 Oct 2026), the refund-or-discount offer or the change for MCP users, which the launch plan put on it.
Why it matters
The missing deletion date is the serious one. The purge runbook treats 18 Oct 2026 as a promise with a deadline because users "were given it in the launch email, the T+23 reminder and on /sunset" — and the page does not say it. Anyone who arrives from a bookmark, from the app's redirect, or from a legacy desktop client loading this page in its own window gets five calm steps about moving to the desktop app and no indication that their data disappears on a date.
The other two are commitments made and not kept in the one place everyone is being sent. PAT-holding MCP clients keep working through the tail and then stop, and nothing on the page tells them so.
Where
surfsense_web/app/%28home%29/sunset/page.tsx— theSTEPSarray and the closing section below it. Steps areGuideStepobjects rendered bycomponents/site/guide-steps.tsx; a step can carry acontrol, anactionor ashot, so most of what you need already exists.surfsense_web/app/%28home%29/sunset/sunset-export.tsx— the paragraph under the export button, which states plainly what does not travel. That is the tone to match: specific, unhedged, no marketing.plans/community-local/portal/02-pages.md— journey 2 is the source of the five things this page was meant to carry. Items 4 and 5 are the ones missing.- Use the existing
ss-home-*primitives andHomeButtonrather than the product's own components. The page renders inside the site design, and mixing the two is visible.
What done looks like
- A reader learns the deletion date without looking for it, and learns it early enough to act on it rather than as a footnote.
- MCP users are told what changes for them and when.
- The refund-or-discount offer appears, or a maintainer records in this issue that it is no longer being made — in which case the doc line changes rather than the page.
- The date is a real date in the copy, not a countdown or anything that needs to stay correct on its own after the day passes.
- Ask before you write items 4 and 5. The refund terms and the MCP cutover detail are commercial facts you cannot infer from the repo. Comment here and wait for a maintainer to supply them; the deletion date is in the architecture doc and needs nobody's permission.
- Delete the Known gaps line from
docs/architecture/sunset.mdin the same PR.
What not to change
Leave the export step first and leave SunsetExport where it is. The comment in page.tsx explains that the button sits inside the step that tells you to export, so the reader meets it in the order they act — and a date-and-refund banner above the fold is exactly the change that would push it down.
How to verify
surfsense_web/tests/unit/sunset-export.test.ts covers this page's exported helpers, and tests/unit/sunset-redirect.test.ts proves /sunset stays publicly reachable. Copy alone needs no test; anything you extract as a function does, written failing first.
cd surfsense_web
pnpm test:unit
Before you start
Read CONTRIBUTING.md, the sunset doc and the page plan linked above. React and UI work in surfsense_web follows the frontend-workflow skill described in AGENTS.md. This page also loads inside the legacy desktop client's own window under contract 4, which requires it to work there with no Electron-specific assumptions — adding copy does not touch that contract, but do not add anything that needs a browser the legacy client is not. This is time-critical: the date it should be announcing is 18 Oct 2026. Open your PR against dev, not main. Comment here to claim this.
- Lingua principale
- Python
- Stelle
- 16.3k
- Fork
- 1.6k
- Merge medio
- 12h 13m
- PR unite (30g)
- 274
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di MODSetter/SurfSense
-
Security Scan: stop flagging pinned hashes and test fixtures on release PRsForse già presa @karthikeya1220 l’ha presa oggi. Apertacode quality security
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
MODSetter/SurfSense#2225 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Check Apple notarization credentials on dry runs and weeklyForse già presa @Cedric921 l’ha presa oggi. Apertadesktop
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
MODSetter/SurfSense#2224 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Release workflow: keep the macOS certificate off the Windows dry-run buildForse già presa @Cedric921 l’ha presa oggi. Apertadesktop security
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
MODSetter/SurfSense#2223 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Write the ADR for chat modesForse già presa @Cedric921 l’ha presa oggi. Apertaarchitecture desktop documentation
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
MODSetter/SurfSense#2220 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di MODSetter/SurfSense
Issue simili
-
customer-reported question
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
Azure/azure-sdk-for-python#49548 · 1 commento · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
btclib-org/btclib-wallet#409 ·
I maintainer di solito rispondono entro 1 giorno
-
Phase 2 PSA Capability & Career Profile
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
bcgov/digital-journeys#2310 ·
-
bug good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
fastmachinelearning/hls4ml#1582 ·
I maintainer di solito rispondono entro 3 giorni
-
Sort modelsApertaenhancement good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
I maintainer di solito rispondono entro 1 giorno