Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[BUG] WebRtcApmModifier: AEC silently does nothing - far-end (reverse) stream is never fed to APM

Aperta
#116 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
52/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
csharp

Direzione di ricerca

Inizia tracciando la registrazione di HandleAudioEngineProcessedForAec di WebRtcApmModifier tramite FullDuplexDevice.OnAudioProcessed, quindi esamina il MasterMixer del dispositivo di riproduzione e il percorso ProcessReverseStream. Il lavoro è completato quando l’APM riceve il segnale di rendering/riproduzione come flusso inverso e l’AEC annulla l’eco catturato, mentre l’elaborazione del near-end rimane intatta.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug
Requirements
  • I have searched the existing issues to ensure this bug has not already been reported.
  • I have provided a clear and concise description of the bug.
  • I have provided detailed steps to reproduce the bug.
  • I have included a minimal reproducible example (MRE) if applicable.
  • I have provided error messages and stack traces if applicable.
  • I have completed the environment information.
1. Describe the Bug

Summary

When using WebRtcApmModifier with AEC enabled on a FullDuplexDevice, the acoustic echo canceller never receives a far-end reference signal, so ProcessReverseStream is effectively never called and echo cancellation does nothing. Noise suppression (NS) and the high-pass filter still work on the near-end capture stream, which makes the audio sound processed and hides the fact that AEC is a no-op.

Root cause

WebRtcApmModifier wires its internal far-end handler (HandleAudioEngineProcessedForAec, which only acts on Capability.Playback frames) to the FullDuplexDevice/engine OnAudioProcessed event. However, that event is raised only for the capture device path — playback/render devices never raise OnAudioProcessed. As a result the handler is only ever called with capture (near-end) frames, which it ignores, and it is never called with the playback (far-end) frames it actually needs. The reverse stream therefore stays empty and AEC has no reference signal.

Suggested fix

The modifier needs to actually receive the render/playback post-mix as the far-end signal. Either:

  • raise the processed-audio event on playback/render devices as well (so the existing Capability.Playback handler gets fed), or
  • inside WebRtcApmModifier, explicitly drive ProcessReverseStream from the playback device's master mixer instead of relying on the capture-only OnAudioProcessed event.
2. Steps to Reproduce
  1. Create a FullDuplexDevice and attach WebRtcApmModifier with aecEnabled: true (NS/HPF on or off — doesn't matter).
  2. Play back a signal on the playback device while capturing on the mic in a shared acoustic path (speakers audible to the mic).
  3. Observe that captured audio still contains the full echo of the playback signal — AEC has no effect. Instrumenting ProcessReverseStream shows it is never called with real render data.
3. Expected Behavior

With aecEnabled: true, the APM's reverse stream should be continuously fed with the render/playback signal (what is being sent to the speakers), so AEC3 can build its reference and cancel echo from the capture stream.

4. Current Behavior

The far-end handler is registered but never invoked with playback audio, so ProcessReverseStream is never driven. AEC produces no cancellation; the caller hears their own echo. Because NS/HPF still run on the near-end, there is no error and the output is not obviously broken — the failure is silent.

5. Minimal Reproducible Example (MRE)

6. Error Messages and Stack Trace (if applicable)

SoundFlow Version

1.4.0

.NET Version

.NET 10.0

Operating System

Windows 11

Architecture

x64

Audio Backend Used (if known)

Full-duplex WASAPI device

Specific Audio Hardware (if relevant)

No response

8. Affected Components/Modules (if known)

SoundFlow.Extensions.WebRtc.Apm 1.4.0

9. Impact

No response

10. Possible Workaround (if known)

I route the playback master-mix into the modifier's private far-end handler ourselves via a small SoundModifier attached to PlaybackDevice.MasterMixer, invoking the internal HandleAudioEngineProcessedForAec with Capability.Playback (currently via reflection, since the method is non-public). The buffer is passed through unmodified. With this in place AEC converges and cancels correctly.

11. Additional Context

No response

Lingua principale
C#
Stelle
512
Fork
56
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di LSXPrime/SoundFlow

Tutte le issue di LSXPrime/SoundFlow

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.