Track outstanding GPU work per allocation for host-accessible arrays
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 45/100
Direzione di ricerca
Start by tracing oneArray's DataRef and the unsafe_convert methods for ZePtr and Ptr, along with scalar indexing and host↔shared unsafe_copyto! paths. Compare the ownership and synchronization behavior described for CUDA.jl, then add tests for broadcast followed by scalar indexing and for a kernel launched from another task and read from the parent. Done means host access synchronizes only dirty buffers on their owning stream, including cross-task and user-queue work.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Arrays backed by SharedBuffer or HostBuffer can be accessed directly from the CPU, so every host access has to wait for outstanding GPU work on the buffer first. #649 fixes the most visible symptom (sum/maximum returning 0) by unconditionally synchronizing the current task's stream in scalar getindex/setindex!. That is correct for the single-task case, but has a few problems:
- Cost. Every element access now does a
device()andglobal_streamtask-local lookup plus azeCommandListHostSynchronize(and a queue sync if oneMKL was used). A CPU loop over a shared array, which is the main reason to make these arrays host-indexable, turns into a driver call per element. - Other tasks. Only the calling task's stream is synchronized. Work on the buffer submitted from another task, or to a user-created queue, is not waited for.
- Other host accesses. Taking a CPU pointer through
unsafe_convert(Ptr{T}, x)(unsafe_wrap(Array, a), passingato a CPUccall, ...) doesn't synchronize at all. The host↔sharedunsafe_copyto!methods each synchronize explicitly to compensate.
How CUDA.jl does it
CUDA.jl wraps every allocation in a Managed object (CUDACore/src/memory.jl) that records the stream that last used it and whether that use has been synchronized:
- Converting the array to a device pointer (
convert(CuPtr, ::Managed), i.e. every kernel launch or copy) callstake_ownership!, which records the current stream and setsdirty = true. Switching to a different stream first syncs the previous owner. - Converting to a host pointer (
convert(Ptr, ::Managed)) callsmaybe_synchronize, which syncs the owning stream only if the allocation is dirty, and then clears the flag.
Scalar indexing goes through pointer(x, I; type=HostMemory), so it needs no explicit synchronization: the first access after GPU work syncs, later ones cost a lock and a Bool check. Because the owning stream is synchronized rather than the caller's, cross-task use works as well. (There's also a captured flag that forces synchronization for memory used during stream capture, which has no oneAPI equivalent yet.)
What oneAPI.jl would need
oneArray.data is a DataRef around the raw oneL0 buffer, so there's no place to keep this state. Roughly:
- Wrap buffers in a small mutable object holding the owning
oneStreamand adirtyflag (plus a lock), at least for host-accessible buffers. - Set ownership and
dirtyinunsafe_convert(::Type{ZePtr{T}}, ::oneArray), synchronizing the previous owner when the stream changes. - Call
maybe_synchronizeinunsafe_convert(::Type{Ptr{T}}, ::oneArray), and drop the explicit synchronization from scalar indexing and from the host↔sharedunsafe_copyto!methods.
Tests should cover broadcast followed by scalar indexing (not just reductions) and a kernel launched from another task and read from the parent.
Possibly related: #458.
- Lingua principale
- Julia
- Stelle
- 217
- Fork
- 37
- Merge medio
- 18h 12m
- PR unite (30g)
- 26
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di JuliaGPU/oneAPI.jl
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Wrong results for overflowing Int16 arithmetic in a reduction kernelForse già presa @maleadt l’ha presa oggi. Aperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
JuliaGPU/oneAPI.jl#663 · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
JuliaGPU/oneAPI.jl#607 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di JuliaGPU/oneAPI.jl
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
oxfordcontrol/COSMO.jl#211 ·
-
documentation
Difficoltà 2/5 Mezza giornata Idoneità per principianti 65/100
I maintainer di solito rispondono entro 6 giorni
-
ARKODE: callbacks that modify `u` throw MethodError on reinitForse già presa @devmotion l’ha presa 1 giorno fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 79/100
SciML/Sundials.jl#575 ·
-
broken links in docsAperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Tube(N) builds N TubeBase segments of length L/(N−1): total friction/inertia length is N·L/(N−1)Forse già presa @ChrisRackauckas-Claude l’ha presa oggi. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
SciML/ModelingToolkitStandardLibrary.jl#525 ·
I maintainer di solito rispondono entro 1 giorno