Deployments: three review nits from the rollout-status change, left as-is

Aperta
  • Qualcosa non va?
#2,059 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
32/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend-api-design, frontend

Direzione di ricerca

Read src/integrations/api/instance/deployments/types.ts, src/features/instance/config/deployments/deploymentsSearch.ts, and src/features/instance/config/deployments/components/DeploymentDetail.tsx alongside the rollout-status change. Check which deferred nit is still worth addressing and trace its current readers or version handling. Done means the issue is resolved by adding a reader, validating status against Harper version, or deciding the behavior is acceptable.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Three review nits on the deployment-status change (claude/funny-lalande-aa0067, Harper 5.4 rolling_out/partial), left as they are on purpose:

  • Deployment.restart_job_id and DeploymentError.nodes have no reader yet (src/integrations/api/instance/deployments/types.ts). They type what Harper writes (harper components/operations.ts:1119/1147, deploymentRecorder.ts partialRollout/finishRollout). The detail view shows a partial record's error.message, which names the same nodes. A "follow the restart job" link would be the first reader of restart_job_id.
  • validateDeploymentsSearch accepts ?status=rolling_out and ?status=partial on any Harper version (src/features/instance/config/deployments/deploymentsSearch.ts). That is the policy staged already has: route validation can't know the version, and the page strips an unsupported status before it sends a request.
  • A node named only in a partial record's error.nodes, with no peer_results row, gets no row under "Other nodes" (src/features/instance/config/deployments/components/DeploymentDetail.tsx). Harper names the same nodes in error.message, which the detail's error block shows, so a node is hidden only if Harper drops it from both.

Close this once either gets a reader or a version-aware route check, or if neither turns out to be worth it.

Review-Deferral: 7ed1786e8f6d66ed severity=nit category=maintainability
Review-Deferral: ac8d50e7cdd33266 severity=nit category=maintainability
Review-Deferral: 79a2f91911c2ff65 severity=nit category=correctness

🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.

Lingua principale
TypeScript
Stelle
5
Fork
4
Merge medio
1g 19h
PR unite (30g)
144

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di HarperFast/studio

Tutte le issue di HarperFast/studio

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.