Deployments: three review nits from the rollout-status change, left as-is

Abierto
  • ¿Algo no está bien?
#2,059 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
32/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend-api-design, frontend

Línea de trabajo

Read src/integrations/api/instance/deployments/types.ts, src/features/instance/config/deployments/deploymentsSearch.ts, and src/features/instance/config/deployments/components/DeploymentDetail.tsx alongside the rollout-status change. Check which deferred nit is still worth addressing and trace its current readers or version handling. Done means the issue is resolved by adding a reader, validating status against Harper version, or deciding the behavior is acceptable.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Three review nits on the deployment-status change (claude/funny-lalande-aa0067, Harper 5.4 rolling_out/partial), left as they are on purpose:

  • Deployment.restart_job_id and DeploymentError.nodes have no reader yet (src/integrations/api/instance/deployments/types.ts). They type what Harper writes (harper components/operations.ts:1119/1147, deploymentRecorder.ts partialRollout/finishRollout). The detail view shows a partial record's error.message, which names the same nodes. A "follow the restart job" link would be the first reader of restart_job_id.
  • validateDeploymentsSearch accepts ?status=rolling_out and ?status=partial on any Harper version (src/features/instance/config/deployments/deploymentsSearch.ts). That is the policy staged already has: route validation can't know the version, and the page strips an unsupported status before it sends a request.
  • A node named only in a partial record's error.nodes, with no peer_results row, gets no row under "Other nodes" (src/features/instance/config/deployments/components/DeploymentDetail.tsx). Harper names the same nodes in error.message, which the detail's error block shows, so a node is hidden only if Harper drops it from both.

Close this once either gets a reader or a version-aware route check, or if neither turns out to be worth it.

Review-Deferral: 7ed1786e8f6d66ed severity=nit category=maintainability
Review-Deferral: ac8d50e7cdd33266 severity=nit category=maintainability
Review-Deferral: 79a2f91911c2ff65 severity=nit category=correctness

🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.

Lenguaje dominante
TypeScript
Estrellas
5
Forks
4
Merge medio
1 d 19 h
PR fusionados (30 d)
144

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de HarperFast/studio

Todos los issues de HarperFast/studio

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.