AutoNAT junk candidates

Aperta
#7,798 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
56/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
networking

Direzione di ricerca

Start in src/libp2p/discovery.rs and find where Identify candidates enter DiscoveryBehaviour::poll. Use libp2p's swarm address-translation helper to map each observed address to the observed IP with the node's listen port for the same transport, then add a unit test covering that translation. Done means the candidate set stays bounded, the translation test passes, and the 25-server reproduction reaches Public status.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Type: Task

[!CAUTION]
Issue AI-generated while investigating connectivity/reachability issues with crawlers.

Summary

Forest nodes behind a NAT that rewrites outgoing ports (Kubernetes, many Docker setups, CGNAT) never confirm their external address, even when their listen port is forwarded and reachable. They stay AutoNAT Private, don't advertise a public address, and are therefore absent from Lotus routing tables and from network measurements (see #7527).

Cause:

  • Identify reports one observed address per connection. Behind such a NAT each outgoing connection is observed with a different port, so every observation is a distinct, undialable candidate. A home node collected 12 of them within seconds of startup.
  • libp2p-autonat (v1, 0.15) only ever adds candidates and never removes them (behaviour.rs:290). Every probe sends all candidates first, followed by our listen addresses (as_client.rs:190-195).
  • The go-libp2p AutoNAT server that Lotus runs dials the observed address plus at most 15 of the requested addresses, substituting the observed IP (p2p/host/autonat/svc.go:150-193, maxPeerAddresses = 16). Once 15 or more junk candidates have accumulated, observed IP + listen port, the only address that would work, is never tried.

Reproduced locally with a calibnet node that was reachable throughout, connected through a port-rewriting proxy to go-libp2p's AutoNAT server code (only change: loopback dial-backs allowed, so the test could run locally):

AutoNAT servers (junk candidates) Probes Status
5 4/4 succeeded Public, listen address confirmed
25 3/3 failed Private

Proposed fix: identify's candidates pass through DiscoveryBehaviour::poll before they reach AutoNAT. Replace each one with observed IP + our listen port for the same transport (libp2p::swarm::_address_translation). The candidate set then stays small and contains the address that actually works for port-forwarded setups (k8s hostPort, Docker -p, cloud 1:1 NAT).

Completion Criteria

  • Translate external address candidates to observed IP + listen port in src/libp2p/discovery.rs
  • Unit test for the translation
  • Verify with the 25-server reproduction: the node reaches Public
  • Report the unbounded candidate set upstream (rust-libp2p autonat v1)

Additional Links & Resources

  • #7527
  • libp2p-autonat 0.15 src/v1/behaviour.rs:290, src/v1/behaviour/as_client.rs:190-195
  • go-libp2p v0.50.0 p2p/host/autonat/svc.go:125-193
Lingua principale
Rust
Stelle
700
Fork
201
Merge medio
1g 17h
PR unite (30g)
65

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ChainSafe/forest

Tutte le issue di ChainSafe/forest

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.