AutoNAT junk candidates

Abierto
#7,798 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
56/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust
Área
networking

Línea de trabajo

Start in src/libp2p/discovery.rs and find where Identify candidates enter DiscoveryBehaviour::poll. Use libp2p's swarm address-translation helper to map each observed address to the observed IP with the node's listen port for the same transport, then add a unit test covering that translation. Done means the candidate set stays bounded, the translation test passes, and the 25-server reproduction reaches Public status.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Type: Task

[!CAUTION]
Issue AI-generated while investigating connectivity/reachability issues with crawlers.

Summary

Forest nodes behind a NAT that rewrites outgoing ports (Kubernetes, many Docker setups, CGNAT) never confirm their external address, even when their listen port is forwarded and reachable. They stay AutoNAT Private, don't advertise a public address, and are therefore absent from Lotus routing tables and from network measurements (see #7527).

Cause:

  • Identify reports one observed address per connection. Behind such a NAT each outgoing connection is observed with a different port, so every observation is a distinct, undialable candidate. A home node collected 12 of them within seconds of startup.
  • libp2p-autonat (v1, 0.15) only ever adds candidates and never removes them (behaviour.rs:290). Every probe sends all candidates first, followed by our listen addresses (as_client.rs:190-195).
  • The go-libp2p AutoNAT server that Lotus runs dials the observed address plus at most 15 of the requested addresses, substituting the observed IP (p2p/host/autonat/svc.go:150-193, maxPeerAddresses = 16). Once 15 or more junk candidates have accumulated, observed IP + listen port, the only address that would work, is never tried.

Reproduced locally with a calibnet node that was reachable throughout, connected through a port-rewriting proxy to go-libp2p's AutoNAT server code (only change: loopback dial-backs allowed, so the test could run locally):

AutoNAT servers (junk candidates) Probes Status
5 4/4 succeeded Public, listen address confirmed
25 3/3 failed Private

Proposed fix: identify's candidates pass through DiscoveryBehaviour::poll before they reach AutoNAT. Replace each one with observed IP + our listen port for the same transport (libp2p::swarm::_address_translation). The candidate set then stays small and contains the address that actually works for port-forwarded setups (k8s hostPort, Docker -p, cloud 1:1 NAT).

Completion Criteria

  • Translate external address candidates to observed IP + listen port in src/libp2p/discovery.rs
  • Unit test for the translation
  • Verify with the 25-server reproduction: the node reaches Public
  • Report the unbounded candidate set upstream (rust-libp2p autonat v1)

Additional Links & Resources

  • #7527
  • libp2p-autonat 0.15 src/v1/behaviour.rs:290, src/v1/behaviour/as_client.rs:190-195
  • go-libp2p v0.50.0 p2p/host/autonat/svc.go:125-193
Lenguaje dominante
Rust
Estrellas
700
Forks
201
Merge medio
1 d 17 h
PR fusionados (30 d)
65

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de ChainSafe/forest

Todos los issues de ChainSafe/forest

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.