Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

memory place says 'memory is off' on the default engine road while memory is on

Aperta
  • Qualcosa non va?
#1,535 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
64/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go
Ambito
backend, cli

Direzione di ricerca

Start with internal/tui3/place_memory.go, internal/tui3/memory.go, and internal/tui3/app.go, then trace the ListMemories path and host adapter from cmd/codeaf/chatv3_host.go. Run the deterministic demo-home replication to compare the engine and --no-host roads. Done means both roads show the same shelves and counts, while memory off shows the off message and row edits are handled or clearly reported.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:chat bug sev:serious

What happened

On dev@c34a3a76d (2026-09-26), the memory place on the default engine road says memory is off, even though memory is on and the store holds memories. The same home on the in-process road shows them. The memory place is reached with alt+8 from a plain codeaf launch.

 memory
   what it has learned about you and this machine · /remember adds a line
─ memory is off for this session · turn it on under /settings ──────────

On the same home, /settings reads memory on, and codeaf chat --no-host draws 11 held · 3 shelves on the same page.

This is not new: the guard below predates v0.4.1, so stable has it too.

Replication

Deterministic (no model). Seed the repository's demo home, which ships 12 memories with memory on, and compare the two roads:

make build
go build -o bin/codeaf-demo-home ./cmd/codeaf-demo-home
bin/codeaf-demo-home --into /tmp/cd-demo     # prints "12 memories"
# use a short state root: the engine's unix socket lives under it
ln -s /tmp/cd-demo/.codeaf /tmp/cdm
cd /tmp/cd-demo/codeaf
HOME=/tmp/cd-demo CODEAF_HOME=/tmp/cdm /path/to/bin/codeaf              # esc past setup, alt+8 → "memory is off for this session"
HOME=/tmp/cd-demo CODEAF_HOME=/tmp/cdm /path/to/bin/codeaf chat --no-host   # alt+8 → "11 held · 3 shelves"

No model call is needed to see it. The page draws before anything is sent.

Where

  • internal/tui3/place_memory.go memoryReady() requires a.brain(). In internal/tui3/memory.go, brain() only accepts an agent that implements the in-process memoryAgent (Remembers/Remember/Forget/Memories). The engine road's remote agent does not implement it, so the store reader that the host already supplies (Memory: memory from newHostMemory in cmd/codeaf/chatv3_host.go) is never consulted. /memories (internal/tui3/app.go, memoryReady()) takes the same wrong branch.
  • A first attempt made the page read a.memory on the engine road, and its unit tests passed with an injected store. The real repro above still printed "memory is off". So something on the engine side also answers "off": the wire's ListMemories path, or the host adapter's error mapping. That is the part left to find.

The fix

The memory place and /memories on the engine road read the engine's store through the host's memory reader. The "off" line appears only when the setting really is off. Row edits either go over the wire or say plainly where they can be done.

Acceptance

End to end, through the real door: the replication above, on the engine road, shows the same shelves and counts as --no-host (11 held · 3 shelves on the demo home) and never prints memory is off for this session. With memory off in /settings, both roads print that line. A tmux e2e subtest in internal/e2e would pin it (a seeded home, alt+8, assert on the shelf count line).

Lingua principale
Go
Stelle
115
Fork
14
Merge medio
9h 37m
PR unite (30g)
755

Preparare l'ambiente

Non abbiamo ancora controllato i file di configurazione di questo progetto. Parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Agent-Field/CodeAF

Tutte le issue di Agent-Field/CodeAF

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.