Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

memory place says 'memory is off' on the default engine road while memory is on

Ouverte
  • Quelque chose ne va pas ?
#1,535 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
64/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
go
Domaine
backend, cli

Piste de recherche

Start with internal/tui3/place_memory.go, internal/tui3/memory.go, and internal/tui3/app.go, then trace the ListMemories path and host adapter from cmd/codeaf/chatv3_host.go. Run the deterministic demo-home replication to compare the engine and --no-host roads. Done means both roads show the same shelves and counts, while memory off shows the off message and row edits are handled or clearly reported.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:chat bug sev:serious

What happened

On dev@c34a3a76d (2026-09-26), the memory place on the default engine road says memory is off, even though memory is on and the store holds memories. The same home on the in-process road shows them. The memory place is reached with alt+8 from a plain codeaf launch.

 memory
   what it has learned about you and this machine · /remember adds a line
─ memory is off for this session · turn it on under /settings ──────────

On the same home, /settings reads memory on, and codeaf chat --no-host draws 11 held · 3 shelves on the same page.

This is not new: the guard below predates v0.4.1, so stable has it too.

Replication

Deterministic (no model). Seed the repository's demo home, which ships 12 memories with memory on, and compare the two roads:

make build
go build -o bin/codeaf-demo-home ./cmd/codeaf-demo-home
bin/codeaf-demo-home --into /tmp/cd-demo     # prints "12 memories"
# use a short state root: the engine's unix socket lives under it
ln -s /tmp/cd-demo/.codeaf /tmp/cdm
cd /tmp/cd-demo/codeaf
HOME=/tmp/cd-demo CODEAF_HOME=/tmp/cdm /path/to/bin/codeaf              # esc past setup, alt+8 → "memory is off for this session"
HOME=/tmp/cd-demo CODEAF_HOME=/tmp/cdm /path/to/bin/codeaf chat --no-host   # alt+8 → "11 held · 3 shelves"

No model call is needed to see it. The page draws before anything is sent.

Where

  • internal/tui3/place_memory.go memoryReady() requires a.brain(). In internal/tui3/memory.go, brain() only accepts an agent that implements the in-process memoryAgent (Remembers/Remember/Forget/Memories). The engine road's remote agent does not implement it, so the store reader that the host already supplies (Memory: memory from newHostMemory in cmd/codeaf/chatv3_host.go) is never consulted. /memories (internal/tui3/app.go, memoryReady()) takes the same wrong branch.
  • A first attempt made the page read a.memory on the engine road, and its unit tests passed with an injected store. The real repro above still printed "memory is off". So something on the engine side also answers "off": the wire's ListMemories path, or the host adapter's error mapping. That is the part left to find.

The fix

The memory place and /memories on the engine road read the engine's store through the host's memory reader. The "off" line appears only when the setting really is off. Row edits either go over the wire or say plainly where they can be done.

Acceptance

End to end, through the real door: the replication above, on the engine road, shows the same shelves and counts as --no-host (11 held · 3 shelves on the demo home) and never prints memory is off for this session. With memory off in /settings, both roads print that line. A tmux e2e subtest in internal/e2e would pin it (a seeded home, alt+8, assert on the shelf count line).

Langage dominant
Go
Étoiles
115
Forks
14
Merge moyen
9 h 37 min
PR mergées (30 j)
755

Préparer son environnement

Nous n'avons pas encore vérifié les fichiers d'installation de ce projet. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de Agent-Field/CodeAF

Toutes les issues de Agent-Field/CodeAF

Issues similaires

Plus d'issues Go

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.