App denies are skipped for every destination on the DHCP port numbers
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- macos, swift
- Domain
- networking, security
Research direction
Read Sources/NetExt/FilterDataProvider.swift around lines 318–332 and 578–595 to trace the DHCP port exemption and app-rule matcher; then inspect Sources/Helper/PFManager.swift around lines 343–345 for related policy behavior. Verify that non-DHCP traffic to ports 67, 68, 546, and 547 follows app denies while legitimate address configuration still works, including traffic through a signed filter.
Written by the indexing model from the issue text.
Description
An app deny is skipped solely because the destination port is a DHCP port number. FilterDataProvider.swift:591 checks [67, 68, 546, 547].contains(conn.remotePort), and line 318 returns Allow before the matcher. The branch does not check the transport or destination address. I ran the copied function with a non-local address and live policy origin, and every listed port returned true. Exchanging traffic with a real endpoint through the signed filter still needs checking.
Steps
- Save an outgoing deny for an app and deliver the live policy.
- Have that app open a connection to a reachable service on port 67, 68, 546 or
- The port-only exemption returns Allow before checking the app deny, regardless of whether the service is DHCP.
Where
Sources/NetExt/FilterDataProvider.swift:318-332Sources/NetExt/FilterDataProvider.swift:578-595Sources/Helper/PFManager.swift:343-345
Done when: Ordinary non-DHCP traffic to these port numbers follows app rules while legitimate address configuration remains available.
Related: #30, #186
I found this reading the code and haven't reproduced it on a signed build yet: traffic exchange with a non-dhcp endpoint through the signed filter needs checking.
- Dominant language
- Swift
- Stars
- 49
- Forks
- 5
- Avg merge
- 16h 48m
- Merged PRs (30d)
- 82
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from isaaclins/freesnitch
-
area:cli documentation good first issue priority:low
Difficulty 1/5 Under an hour Newbie friendliness 94/100
isaaclins/freesnitch#430 ·
Maintainers usually reply within 1 day
-
area:gui bug priority:low status:queued
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
isaaclins/freesnitch#428 ·
Maintainers usually reply within 1 day
-
area:shared bug priority:high status:queued type:correctness
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
isaaclins/freesnitch#284 ·
Maintainers usually reply within 1 day
-
area:helper bug priority:medium status:queued type:diagnostics
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
isaaclins/freesnitch#282 ·
Maintainers usually reply within 1 day
-
area:gui bug priority:low status:queued type:correctness
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
isaaclins/freesnitch#281 ·
Maintainers usually reply within 1 day
All issues in isaaclins/freesnitch
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
good first issue help wanted testing
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day