A lost helper reply leaves the Insights recording switch unconfirmed
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 50/100
Research direction
Read Sources/GUI/App/HelperClient.swift:423-436 and 544-561 to understand the helper connection and error handling, then trace the recording operation at 777-785 and switch behavior in Sources/GUI/Views/InsightsView.swift:939-949. Reproduce the interrupted request on a signed build and check how reconnection affects the displayed value. Done when a lost reply produces a visible result and the switch reflects a helper-confirmed value.
Written by the indexing model from the issue text.
Description
HelperClient.swift:544-546 creates the shared proxy with the empty error handler { _ in }. The recording operation at lines 777-785 completes only through its reply, while InsightsView.swift:939-949 changes the switch first and rolls it back only on a failed completion. A transport failure can therefore leave the requested value displayed without confirmation. The general helper banner can show the disconnect, but reconnection bootstraps AppState rather than rerunning this model's once-only attachment; this does not establish that recording actually changed.
Steps
- Start with Insights recording off, then switch it on.
- On a controlled installation, interrupt the helper connection before the operation commits or replies.
- Observe the general disconnect banner.
- The switch keeps its optimistic on value without an operation-specific failure until another refresh reconciles it.
Where
Sources/GUI/App/HelperClient.swift:423-436Sources/GUI/App/HelperClient.swift:544-561Sources/GUI/App/HelperClient.swift:777-785Sources/GUI/Views/InsightsView.swift:744-748Sources/GUI/Views/InsightsView.swift:939-949
Done when: A lost recording reply ends the pending action with a visible result and a helper-confirmed switch value.
Related: #246, #267
I found this reading the code and haven't reproduced it on a signed build yet: interrupting an in-flight recording request and checking reconnection behavior needs a signed-build check.
- Dominant language
- Swift
- Stars
- 49
- Forks
- 5
- Avg merge
- 16h 48m
- Merged PRs (30d)
- 82
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from isaaclins/freesnitch
-
area:cli documentation good first issue priority:low
Difficulty 1/5 Under an hour Newbie friendliness 94/100
isaaclins/freesnitch#430 ·
Maintainers usually reply within 1 day
-
area:gui bug priority:low status:queued
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
isaaclins/freesnitch#428 ·
Maintainers usually reply within 1 day
-
area:shared bug priority:high status:queued type:correctness
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
isaaclins/freesnitch#284 ·
Maintainers usually reply within 1 day
-
area:helper bug priority:medium status:queued type:diagnostics
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
isaaclins/freesnitch#282 ·
Maintainers usually reply within 1 day
-
area:gui bug priority:low status:queued type:correctness
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
isaaclins/freesnitch#281 ·
Maintainers usually reply within 1 day
All issues in isaaclins/freesnitch
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
good first issue help wanted testing
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day