Insights overflow counts are discarded before the next permitted warning

Open Beginner friendly
#280 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
macos, swift
Domain
observability

Research direction

Read Sources/NetExt/ObservationQueue.swift:35-45,72-76 and Sources/NetExt/FilterDataProvider.swift:465-488,509-515 to trace when overflow counts are collected and warnings are rate limited. Check the existing diagnostics in Sources/NetExt/HelperClient.swift:716-739 for context. Adjust the accounting so rate limited drops are included in a later warning; verify repeated overflows and warning counts on a signed build.

Written by the indexing model from the issue text.

Description

area:netext bug priority:medium status:queued type:diagnostics

ObservationQueue.swift:72-76 clears fullDrops whenever takeFullDropCount() is called. FilterDataProvider.swift:509-514 calls it before checking Date().timeIntervalSince(lastObservationDropLog) >= 60, so counts taken during that interval disappear without being logged later. The first eligible overflow warning still works, and GUI-to-helper delivery failures have separate diagnostics in HelperClient.swift:716-739. Dropping batches when the GUI is absent is documented behavior; the defect here is losing accumulated overflow accounting.

Steps

  1. Generate an observation-queue overflow and let its warning be logged.
  2. Generate another overflow and drain within the next sixty seconds.
  3. After the warning interval, let the queue drain again.
  4. The suppressed overflow count has already been reset and is missing from the later warning.

Where

  • Sources/NetExt/ObservationQueue.swift:35-45
  • Sources/NetExt/ObservationQueue.swift:72-76
  • Sources/NetExt/FilterDataProvider.swift:465-488
  • Sources/NetExt/FilterDataProvider.swift:509-515

Done when: Every full-queue drop remains included in a later diagnostic count even when warnings are rate limited.

Related: #131

I found this reading the code and haven't reproduced it on a signed build yet: repeated observation overflows and the emitted warning counts need a signed-build check.

Dominant language
Swift
Stars
49
Forks
5
Avg merge
16h 48m
Merged PRs (30d)
82

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from isaaclins/freesnitch

All issues in isaaclins/freesnitch

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.