Insights overflow counts are discarded before the next permitted warning
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- macos, swift
- Domain
- observability
Research direction
Read Sources/NetExt/ObservationQueue.swift:35-45,72-76 and Sources/NetExt/FilterDataProvider.swift:465-488,509-515 to trace when overflow counts are collected and warnings are rate limited. Check the existing diagnostics in Sources/NetExt/HelperClient.swift:716-739 for context. Adjust the accounting so rate limited drops are included in a later warning; verify repeated overflows and warning counts on a signed build.
Written by the indexing model from the issue text.
Description
ObservationQueue.swift:72-76 clears fullDrops whenever takeFullDropCount() is called. FilterDataProvider.swift:509-514 calls it before checking Date().timeIntervalSince(lastObservationDropLog) >= 60, so counts taken during that interval disappear without being logged later. The first eligible overflow warning still works, and GUI-to-helper delivery failures have separate diagnostics in HelperClient.swift:716-739. Dropping batches when the GUI is absent is documented behavior; the defect here is losing accumulated overflow accounting.
Steps
- Generate an observation-queue overflow and let its warning be logged.
- Generate another overflow and drain within the next sixty seconds.
- After the warning interval, let the queue drain again.
- The suppressed overflow count has already been reset and is missing from the later warning.
Where
Sources/NetExt/ObservationQueue.swift:35-45Sources/NetExt/ObservationQueue.swift:72-76Sources/NetExt/FilterDataProvider.swift:465-488Sources/NetExt/FilterDataProvider.swift:509-515
Done when: Every full-queue drop remains included in a later diagnostic count even when warnings are rate limited.
Related: #131
I found this reading the code and haven't reproduced it on a signed build yet: repeated observation overflows and the emitted warning counts need a signed-build check.
- Dominant language
- Swift
- Stars
- 49
- Forks
- 5
- Avg merge
- 16h 48m
- Merged PRs (30d)
- 82
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from isaaclins/freesnitch
-
area:cli documentation good first issue priority:low
Difficulty 1/5 Under an hour Newbie friendliness 94/100
isaaclins/freesnitch#430 ·
Maintainers usually reply within 1 day
-
area:gui bug priority:low status:queued
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
isaaclins/freesnitch#428 ·
Maintainers usually reply within 1 day
-
area:shared bug priority:high status:queued type:correctness
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
isaaclins/freesnitch#284 ·
Maintainers usually reply within 1 day
-
area:helper bug priority:medium status:queued type:diagnostics
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
isaaclins/freesnitch#282 ·
Maintainers usually reply within 1 day
-
area:gui bug priority:low status:queued type:correctness
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
isaaclins/freesnitch#281 ·
Maintainers usually reply within 1 day
All issues in isaaclins/freesnitch
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
good first issue help wanted testing
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day