An earlier uninstall cleanup failure can be reported as success
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 66/100
Research direction
Start with the privileged script construction and error handling in Sources/GUI/App/PrivilegedUninstall.swift:36-50 and :76-90, then trace how its result reaches Sources/GUI/Views/UninstallView.swift:82-99. Check how each required cleanup command's failure is captured and how the UI reports it before moving the app to Trash. Done means a failed pf or data cleanup step returns a visible failure and identifies the step; the issue notes this has not been reproduced on a signed build.
Written by the indexing model from the issue text.
Description
Both privileged uninstall scripts separate required commands with semicolons, including '/sbin/pfctl -a puresnitch -F all;' and '/sbin/pfctl -a puresnitch -f /dev/null;'. In removeDatabase mode, the Insights-directory deletion is also followed by a database deletion, so an earlier failure can be hidden by a successful final command. PrivilegedUninstall.run then sees no AppleScript error, and UninstallFlowModel moves the app to Trash and displays completion.
Steps
- Start uninstall and authorize it.
- A required pf flush or earlier data-removal command fails, while the final database-removal command succeeds.
- Because the script continues and ends successfully, run returns success.
- The app is removed and the user sees uninstall complete even though firewall rules or requested data may remain.
Where
Sources/GUI/App/PrivilegedUninstall.swift:36-50Sources/GUI/App/PrivilegedUninstall.swift:76-90Sources/GUI/Views/UninstallView.swift:82-99
Done when: Any failed required pf or data cleanup operation makes the privileged action return a failure, keeps the uninstall result visibly incomplete, and identifies the failed step before the app is moved to Trash.
Related: #211
I found this reading the code and haven't reproduced it on a signed build yet.
- Dominant language
- Swift
- Stars
- 49
- Forks
- 5
- Avg merge
- 16h 48m
- Merged PRs (30d)
- 82
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from isaaclins/freesnitch
-
area:cli documentation good first issue priority:low
Difficulty 1/5 Under an hour Newbie friendliness 94/100
isaaclins/freesnitch#430 ·
Maintainers usually reply within 1 day
-
area:gui bug priority:low status:queued
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
isaaclins/freesnitch#428 ·
Maintainers usually reply within 1 day
-
area:shared bug priority:high status:queued type:correctness
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
isaaclins/freesnitch#284 ·
Maintainers usually reply within 1 day
-
area:helper bug priority:medium status:queued type:diagnostics
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
isaaclins/freesnitch#282 ·
Maintainers usually reply within 1 day
-
area:gui bug priority:low status:queued type:correctness
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
isaaclins/freesnitch#281 ·
Maintainers usually reply within 1 day
All issues in isaaclins/freesnitch
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
good first issue help wanted testing
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day