The helper writes raw DNS names and paths as public system-log text

Open
#264 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
57/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
macos, swift

Research direction

Read Sources/Shared/Logger.swift:12-14 and inspect the listed logging calls in HelperService.swift and BundlePresenceWatcher.swift to see which values are written as public text. Start by checking the project’s logging and diagnostic disclosure conventions. Done means failure context remains useful while DNS names, paths, endpoints, and configured URLs are private or omitted unless the user opts in.

Written by the indexing model from the issue text.

Description

area:helper bug priority:medium status:queued type:security

Each PSLog function formats the whole message as %{public}@, so interpolated values are not privacy-redacted. The helper includes queried hostnames, resolver URLs, IPs, bundle paths, and filesystem paths in these messages; for example, line 99 logs domain and line 565 logs the rejected stored URL. Apple documents .public values as visible in unified logs (OSLogPrivacy.public).

Steps

  1. A DNS ask for an internal or personal hostname cannot be delivered to the GUI, so HelperService logs the domain.
  2. The log is inspected by a local account or support collector with unified-log access, or included in a diagnostic capture the user shares.
  3. Because the message is public rather than redacted, that reader learns the hostname and any other raw values in the captured messages.

Where

  • Sources/Shared/Logger.swift:12-14
  • Sources/Helper/HelperService.swift:99-111
  • Sources/Helper/HelperService.swift:159
  • Sources/Helper/HelperService.swift:559-570
  • Sources/Helper/BundlePresenceWatcher.swift:287-288

Done when: System logs retain useful failure context while DNS names, user paths, endpoint values and configured URLs are private or omitted unless a user explicitly opts into diagnostic disclosure.

I found this reading the code.

Dominant language
Swift
Stars
49
Forks
5
Avg merge
16h 48m
Merged PRs (30d)
82

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from isaaclins/freesnitch

All issues in isaaclins/freesnitch

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.