Running mypy via precommit with --install-type --non-interactive seem to silence some errors

Open
#1,336 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start with .pre-commit-config.yaml and reproduce the two pre-commit mypy commands shown in the issue. Compare the behavior with and without --non-interactive, then check the reported errors in ipykernel/pylab/config.py, ipykernel/pylab/backend_inline.py, and ipykernel/ipkernel.py. Done means the cause of the differing diagnostics is established and the intended configuration behavior is documented or fixed.

Written by the indexing model from the issue text.

Description

$ git diff ; pre-commit run --all-files --hook-stage manual mypy
mypy.....................................................................Passed

But:

$ git diff ; pre-commit run --all-files --hook-stage manual mypy
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 62514712..06f52541 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -44,7 +44,6 @@ repos:
     hooks:
       - id: mypy
         files: ipykernel
-        args: ["--install-types", "--non-interactive"]
         additional_dependencies:
           [
             "traitlets>=5.13",
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

ipykernel/pylab/config.py:8: error: Unused "type: ignore" comment
[unused-ignore]
    from matplotlib_inline.config import *  # type:ignore[import-untyped] ...
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
ipykernel/pylab/backend_inline.py:8: error: Unused "type: ignore" comment
[unused-ignore]
    from matplotlib_inline.backend_inline import *  # type:ignore[import-u...
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
ipykernel/ipkernel.py:162: error: Unused "type: ignore" comment
[unused-ignore]
                import appnope  # type:ignore[import-untyped]
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 3 errors in 3 files (checked 48 source files)

It seem to be just --install-types

$ git diff ; pre-commit run --all-files --hook-stage manual mypy
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 62514712..e56cd12c 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -44,7 +44,7 @@ repos:
     hooks:
       - id: mypy
         files: ipykernel
-        args: ["--install-types", "--non-interactive"]
+        args: ["--install-types"]
         additional_dependencies:
           [
             "traitlets>=5.13",
mypy.....................................................................Passed

I also get way more errors running mypy manually, but I think this is because of missing dependencies.

Dominant language
Python
Stars
734
Forks
411
Avg merge
1d 2h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ipython/ipykernel

All issues in ipython/ipykernel

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.