datastore-s3 throws the wrong error when a file isn't found on s3
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- aws, typescript
Research direction
Start in packages/datastore-s3/src/index.ts at the 404 status check linked in the issue, and compare its error handling with packages/datastore-fs/src/index.ts. Confirm the behavior through the helia.pins.add or helia.pins.ls entry points; a missing S3 file should produce NotFoundError rather than GetFailedError.
Written by the indexing model from the issue text.
Description
When using datastore-s3, calling helia.pins.add or helia.pins.ls fails with a "NoSuchKey" error
err: {
"type": "GetFailedError",
"message": "NoSuchKey: The specified key does not exist.",
If a file isn't found a "NotFoundError" is gracefully handled, but a GetFailedError throws. datastore-s3's "get" method currently throws a GetFailedError when a given file isn't found.
This is because the 404 status check doesn't line up with the response from s3 (this line)
Applied the following patch to fix:
diff --git a/dist/src/index.js b/dist/src/index.js
index 3dc550c3fa0abaf3c6c1fe7bb7ca4107c824ba3d..88f43d0939f9dbc754097723c0bcab15fdacae88 100644
--- a/dist/src/index.js
+++ b/dist/src/index.js
@@ -113,7 +113,7 @@ export class S3Datastore extends BaseDatastore {
return await toBuffer(data.Body);
}
catch (err) {
- if (err.statusCode === 404) {
+ if (err.statusCode === 404 || err.$metadata.httpStatusCode === 404 || String(err).includes('NoSuchKey')) {
throw new NotFoundError(String(err));
}
throw new GetFailedError(String(err));
- Dominant language
- TypeScript
- Stars
- 39
- Forks
- 28
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ipfs/js-stores
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
need/triage
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
feat: create new core data & blockstore that acts as a cache/buffered storeMay be free again @SgtPooki claimed this 1046 days ago, and no pull request is open. Opendif/medium effort/days kind/enhancement P1 status/in-progress
-
need/triage
Difficulty 1/5 Under an hour Newbie friendliness 45/100
-
datastore-idb .query doesn't work as expectedMay be free again A pull request for this issue was closed without being merged. Openkind/bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Similar issues
-
area:cli area:security bug priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
"code source" and "numerique.gouv" links: "new window" mention duplicated in the accessible nameOpenaccessibility
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
numerique-gouv/lasuite-landingpage#315 ·
Maintainers usually reply within 1 day
-
needs:triage
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
HyeokjaeChoi/vaultme#585 ·
Maintainers usually reply within 1 day
-
enhancement priority/P2
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
beettlle/pi-smart-router#200 ·