Recent updates to `Dossier.prepare_dataframes`

Closed Beginner friendly
#160 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

A pull request for this has already been merged.

  • #173 by @amotl — merged

Assessment

Difficulty
2/5
Estimated time
Under an hour
Newbie friendliness
70/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
data

Research direction

Open patzilla/navigator/export.py and inspect lines 97-109 in Dossier.prepare_dataframes to find the unused lst variable from commit 9f2ae3b. Determine whether to remove it or integrate it into the dataframe setup. Done when lst is either used or deleted and existing tests pass.

Written by the indexing model from the issue text.

Description

needs discussion

Dear @papoteur-mga,

thank you for helping to improve the codebase. Regarding your recent commit 9f2ae3b47cb3caa07c0b2f704e7fb1295aeaa93c, I can see the newly introduced lst variable is never used yet. Is it possible that the fix wasn't complete?

https://github.com/ip-tools/patzilla/blob/9bca37edcdf2c9d197d151ae17abcfac438c75c8/patzilla/navigator/export.py#L97-L109

With kind regards,
Andreas.

Dominant language
Python
Stars
123
Forks
31
Avg merge
3h 7m
Merged PRs (30d)
71

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ip-tools/patzilla

All issues in ip-tools/patzilla

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.