uninstall.sh --data removes the projects folder without naming it
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start in scripts/uninstall.sh, focusing on the removal logic and the list shown before the confirmation prompt; also check the --data and --all help text. Add tests using stand-in folders created by the tests, covering the printed paths, declining removal, and refusing an empty setting. Done when those tests pass and the tests remove only their own folders.
Written by the indexing model from the issue text.
Description
What is wrong
scripts/uninstall.sh --data (and --all) removes two folders: the
data folder (ATLAS_DATA_DIR) and the projects folder
(ATLAS_PROJECTS_DIR). The list it prints before its question names
only the first: "Persistent data (PVCs and )".
The projects folder holds a user's own work. The config example
marks that key "CHANGE THIS: User project workspace". So a user who
answers yes loses that folder without having been told.
What needs doing
- The list before the question names every folder that the chosen
options remove, each with its path. - The help text of
--dataand--allsays the same. - A setting that is empty is refused with a clear message, before
anything is removed.
Done when
- A test with stand-in folders: the output names both folders
before the question, and with the answer "no" nothing is removed. - A test: an empty value stops the script with a message, and
nothing is removed. - The tests remove only folders that they made themselves.
Where to start
scripts/uninstall.sh: the part that removes the data, and the
list before the question.
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 197
- Avg merge
- 5h 19m
- Merged PRs (30d)
- 76
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from inferstep/ATLAS
-
area/install reliability
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Installer and setup guide: say what the docker group givesPossibly taken A pull request linked to this issue is open or already merged. Openarea/install documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area/cli
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
area/proxy reliability status/ready
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
docs/quality/rules.md: the rules learned from review, and the two-rounds rulePossibly taken A pull request linked to this issue is open or already merged. Openarea/ci documentation status/ready
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
epam/ai-dial-quickapps-backend#628 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 69/100
timqian/chinese-independent-blogs#2235 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
eclipse-score/coverage_tool#27 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
bojieli/ai-agent-book#1174 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
RedHatQE/mtv-api-tests#721 ·
Maintainers usually reply within 1 day