Model install: check the hash of every file before it is used
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 75/100
Research direction
Start with atlas/commands/model.py and atlas/commands/model_registry.py, then trace the four install paths in the issue: registry hashes, --url, existing model files, and .part files. Run the relevant tests without a GPU or model. Done means one test covers each path and the summary uses fixed wording for verified (sha256) and not verified.
Written by the indexing model from the issue text.
Description
What needs doing
- Give the registry entries that have no
sha256a hash, or mark
them in the model list. atlas model install --urlaccepts--sha256. Without it the
summary says "not verified".- A file that is already in the models folder is hashed before it
is kept, when the registry has a hash for it. - A
.partfile with no registry hash is never reported as
verified on a size match alone.
Why
These four paths go on with a note today. A damaged or wrong file is
then found only when the model fails to load.
Done when
- One test per path.
- The install summary uses one fixed wording for "verified
(sha256)" and for "not verified".
Where to start
atlas/commands/model.py,atlas/commands/model_registry.py.- No GPU or model is needed for the tests.
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 197
- Avg merge
- 14h 1m
- Merged PRs (30d)
- 155
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from inferstep/ATLAS
-
Bootstrap: the last two steps run as the user who owns the installMay be free again @assassinationss claimed this 9 days ago, and no pull request is open. Openarea/install reliability
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
inferstep/ATLAS#412 · 4 comments ·
Maintainers usually reply within 1 day
-
area/cli
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
A `sandbox_subdir` the proxy does not accept is refused, not ignoredPossibly taken @mvanhorn claimed this 5 days ago. Openarea/proxy reliability
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
inferstep/ATLAS#364 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
area/cli area/lens status/ready
Difficulty 2/5 Half a day Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
area/ci status/ready
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
inferstep/ATLAS#245 · 4 comments ·
Maintainers usually reply within 1 day
Similar issues
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ianktoo/project-monitor#14 ·
-
security
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
btclib-org/btclib-wallet#478 ·
Maintainers usually reply within 1 day
-
security
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
btclib-org/btclib#2727 ·
Maintainers usually reply within 1 day
-
good first issue lead variant:container
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
radialmonster/orf-cleanroom#10 ·
Maintainers usually reply within 1 day
-
gdsa opencode: keep-alive cleanup trap fails with 'keepalive_pid: unbound variable'Possibly taken @darribas claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100