ImageFill + splitview: sometimes vertical pictures are cropped instead of showin in split view

Open
  • Is something wrong?
#541 4 comments 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
csharp, docker
Domain
frontend

Research direction

Start with the ImageFill and Layout=splitview settings that the reporter sets in compose.yaml, then find where the slideshow decides between single and split display for portrait images. Reproduce by advancing through images on a landscape screen until a portrait image appears cropped in single view. Done means portrait images are reliably shown side by side in split view when ImageFill is enabled, and the cause of the intermittent behaviour is understood.

Written by the indexing model from the issue text.

Description

bug
Version

v1.0.30.0 (image: ghcr.io/immichframe/immichframe:latest)

Deployment Method

Web (Docker)

Description

I have the following combination of settings in my compose.yaml:

      ImageFill: "true"
      Layout: "splitview"

I use it on a horizontal screen.

Expected result
  1. If it is a landscape image: zoom to fill the entire screen, crop if necessary
  2. If it is a portrait/vertical image: Switch to split view, display two portrait images side by side and zoom each side to fill the entire side, crop if necessary
What is happening
  1. works as intended
  2. Quite often, the portrait images are not shown in split view and are then cropped to fill the screen. For portrait images, this crops too much from the images, so that sometimes e.g. only the nose and mouth of a person is visible. This does look very bad.

If I disable ImageFill, then the effect is not as bad (because I see the complete portrait images), but then I always do have the blurred borders - even for landscape images (because my screen does not match the aspect ratio of the images).

Can the split view be enforced for portrait images? Why are portrait images are sometimes shown in split view and sometimes not (even the same image shows up in both split and non-split view)?

If you need any more information, please let me know.

Reproduction

Set the settings as described above. Then click to show the next image some times. Quickly, a portrait image in single, cropped view does come up.

Expectations

No response

Configuration
Logs
Pre-Submission Checklist

  • This is a bug report and not a feature request

  • I have provided all of the required information to reproduce the bug (config, logs, etc.)

  • I have checked for related issues and checked the documentation

Dominant language
C#
Stars
2.4k
Forks
121
Avg merge
18d 20h
Merged PRs (30d)
1

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from immichFrame/ImmichFrame

All issues in immichFrame/ImmichFrame

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.