ImageFill + splitview: sometimes vertical pictures are cropped instead of showin in split view

Abierto
  • ¿Algo no está bien?
#541 4 comentarios 7 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
csharp, docker
Área
frontend

Línea de trabajo

Start with the ImageFill and Layout=splitview settings that the reporter sets in compose.yaml, then find where the slideshow decides between single and split display for portrait images. Reproduce by advancing through images on a landscape screen until a portrait image appears cropped in single view. Done means portrait images are reliably shown side by side in split view when ImageFill is enabled, and the cause of the intermittent behaviour is understood.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
Version

v1.0.30.0 (image: ghcr.io/immichframe/immichframe:latest)

Deployment Method

Web (Docker)

Description

I have the following combination of settings in my compose.yaml:

      ImageFill: "true"
      Layout: "splitview"

I use it on a horizontal screen.

Expected result
  1. If it is a landscape image: zoom to fill the entire screen, crop if necessary
  2. If it is a portrait/vertical image: Switch to split view, display two portrait images side by side and zoom each side to fill the entire side, crop if necessary
What is happening
  1. works as intended
  2. Quite often, the portrait images are not shown in split view and are then cropped to fill the screen. For portrait images, this crops too much from the images, so that sometimes e.g. only the nose and mouth of a person is visible. This does look very bad.

If I disable ImageFill, then the effect is not as bad (because I see the complete portrait images), but then I always do have the blurred borders - even for landscape images (because my screen does not match the aspect ratio of the images).

Can the split view be enforced for portrait images? Why are portrait images are sometimes shown in split view and sometimes not (even the same image shows up in both split and non-split view)?

If you need any more information, please let me know.

Reproduction

Set the settings as described above. Then click to show the next image some times. Quickly, a portrait image in single, cropped view does come up.

Expectations

No response

Configuration
Logs
Pre-Submission Checklist

  • This is a bug report and not a feature request

  • I have provided all of the required information to reproduce the bug (config, logs, etc.)

  • I have checked for related issues and checked the documentation

Lenguaje dominante
C#
Estrellas
2.4k
Forks
121
Merge medio
18 d 20 h
PR fusionados (30 d)
1

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de immichFrame/ImmichFrame

Todos los issues de immichFrame/ImmichFrame

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.