Docker images in manifest file allow mismatched tag + sha
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Read pkg/types/manifest.go at the referenced image-name generation method first. Trace how manifest.json values become docker-compose image references, then define behavior for mismatched tag and sha; done means mismatches are detected or the manifest format is revised, with tests covering the chosen behavior.
Written by the indexing model from the issue text.
Description
The manifest.json format allows specifying a Docker version by tag or sha. If the sha is set, the tag is ignored, as seen in this method to generate the image name for the docker-compose file:
This can be confusing if tag and sha are both set but refer to two different images. Ideally if both are set, there would be some verification that they point to the same image.
If this is not feasible, perhaps we should adjust the manifest.json to only contains sha (even though it's not as human-readable).
- Dominant language
- Go
- Stars
- 66
- Forks
- 64
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperledger-firefly/cli
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
hyperledger-firefly/cli#357 ·
-
bug good first issue
Difficulty 3/5 1-2 days Newbie friendliness 45/100
hyperledger-firefly/cli#343 · 1 comment ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
hyperledger-firefly/cli#339 · 7 comments ·
-
bug Windows WSL
Difficulty 3/5 1-2 days Newbie friendliness 25/100
hyperledger-firefly/cli#335 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
hyperledger-firefly/cli#334 · 2 comments ·
All issues in hyperledger-firefly/cli
Similar issues
-
Mend: dependency security vulnerability
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
kube-tarian/sigrun#202 ·
-
question raised-by:verifier
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
medici-finance/assay#4013 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
tsukumogami/tsuku#2775 ·
Maintainers usually reply within 1 day
-
automation models
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
Maintainers usually reply within 1 day