Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

CLI attempts to pull "local" Docker images (and fails)

Open
  • Is something wrong?
#119 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

  • #144 by @awrichar — closed without merging

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
docker, go
Domain
cli, devops

Research direction

Start in internal/stacks/stack_manager.go at PullStack and reproduce the issue with ff start and a manifest.json containing a local Docker definition. Trace the manifest images and the blockchain/token plugin images to determine which Dockers are actually used. Done means ff start pulls only used images while preserving manifest versions and skipping images marked local.

Written by the indexing model from the issue text.

Description

If you point the CLI to a local manifest with -m manifest.json, and that manifest contains a local Docker definitions such as:

  "tokens-erc1155": {
    "image": "ghcr.io/hyperledger/firefly-tokens-erc1155",
    "local": true
  }

When running ff start, the CLI still pulls the latest image from the server, overwriting the local image.

This seems to be due to a duplication in the PullStack method here. It first iterates the images defined in the manifest, and does properly skip those tagged as local. But then it goes on to pull the latest for all images defined by the blockchain and token plugins, defeating the purpose of the earlier loop.

Side node: because it first pulls all the images defined in the manifest, it will pull images even if you're ultimately not using them (ie it pulls fabconnect even if your blockchain provider is Ethereum).

Conclusion from all this: we need better "pull" logic to intersect the info from these two places - it should only pull the Dockers actually used in the stack, but it should also honor the versions and "local" flag defined for those images in the manifest.

Dominant language
Go
Stars
66
Forks
64
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from hyperledger-firefly/cli

All issues in hyperledger-firefly/cli

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.