cli_bundled_plugins_activated: guard the V1_EXCLUDED_FROM_DEFAULT loops against an empty set registering zero assertions
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- testing
Research direction
Read hypaware-core/smoke/flows/cli_bundled_plugins_activated.js at lines 164 and 302, then check how V1_EXCLUDED_FROM_DEFAULT feeds the .some() check and status loop. The issue is done when the flow asserts the set is non-empty before those loops, or the smoke harness detects a declared block that registers no assertions; this is marked backlog-only unless a human delegates it.
Written by the indexing model from the issue text.
Description
Source: #2082 at e605654231012936fad1c717001cb217d79738ce
Location: hypaware-core/smoke/flows/cli_bundled_plugins_activated.js:164 and :302
Severity: minor
Evidence
The .some() check and the per-name status loop both derive from V1_EXCLUDED_FROM_DEFAULT; if that set were ever emptied the loop registers zero assertions and the .some() check goes vacuously true, and the smoke harness has no assertion counter to notice. M6 (emptying the set) was RED on both master and head, failing loudly on the roster-count assertion, so the vacuity is not silently reachable today.
Why deferral is safe
No incorrect behavior observed: reaching the vacuity requires emptying V1_EXCLUDED_FROM_DEFAULT and simultaneously losing the roster-count assertion that M6 shows fails loudly. Speculative hardening (a non-empty guard or a harness assertion counter), safely left outside PR #2082.
Acceptance condition
Either the flow asserts V1_EXCLUDED_FROM_DEFAULT is non-empty before the loops, or the smoke harness counts registered assertions and fails a flow that registers none for a declared block.
Review preference; backlog only. A human may explicitly delegate it with neutral:fix.
- Dominant language
- JavaScript
- Stars
- 11
- Forks
- 0
- Avg merge
- 2h 49m
- Merged PRs (30d)
- 302
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyparam/hypaware
-
docs: ollama.md says --source ollama adds to an existing install, but without --force it refusesOpen
Difficulty 2/5 Under an hour Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
report_commands.js runtime output still says 'server' in four places; one names the destinationOpen
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 76/100
Maintainers usually reply within 1 day
All issues in hyparam/hypaware
Similar issues
-
needs-area-label
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 2 days
-
serienstream.toOpenN: AdGuard for Windows P2: High T: Annoyance
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
AdguardTeam/AdguardFilters#246310 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
liberation-data/drivine#615 ·
Maintainers usually reply within 1 day
-
bug dependencies known-issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
unreleased dependencies
Difficulty 1/5 Under an hour Newbie friendliness 72/100
cloudfour/eslint-config#760 ·
Maintainers usually reply within 1 day