Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Prices after tax

Open
  • Is something wrong?
#29 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
65/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
backend

Research direction

Start with docs/opportunity-scoring.md and its worked example, then trace how sale proceeds and craft margins are calculated and where recorded Universalis tax rates enter the data. Update the calculations so margins use the recorded rate, and revise the example to match; done when both agree for recorded data.

Written by the indexing model from the issue text.

Description

enhancement

Sale proceeds and craft margins subtract the market tax of the retainers' city (Universalis tax rates). The rates arrive undated from players' uploads, so Market names the city and rate used. Listed under "Changes from v1" in docs/opportunity-scoring.md.

Done when

  • Margins on recorded data are net of the recorded tax rate, and the scoring doc's worked example matches.
Dominant language
C#
Stars
0
Forks
1
Avg merge
23m
Merged PRs (30d)
7

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from hazeliscoding/gil-sweep

All issues in hazeliscoding/gil-sweep

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.