Removing 'search' unused query selector
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, jekyll
Research direction
In assets/js/current-projects.js, locate the two #search selectors named in the issue and remove them from the selector lists. Then test searches in desktop and mobile views on the Projects and Projects-Check pages, using Chrome DevTools device mode for mobile if helpful. Done means searches still work in both views on both pages.
Written by the indexing model from the issue text.
Description
Overview
We need to remove query selectors for 'search' since there is no existing id for 'search' in '_includes/current-projects.html'
Action Items
-
locate the 2 instances of 'document.querySelector('#search')' in 'assets/js/current-projects.js'
-
make the following revisions to 'asstes/js/current-projects.js'
Before:const allInputEl = Array.from(document.querySelectorAll('#search-desktop, #search-mobile, #search'));After removing
#search:const allInputEl = Array.from(document.querySelectorAll('#search-desktop, #search-mobile'));Before:
function searchCloseEventHandler(e){ e.preventDefault(); const input = document.querySelector('#search-desktop') || document.querySelector('#search-mobile') || document.querySelector('#search'); if (input) input.value=""; }After removing
document.querySelector('#search'):function searchCloseEventHandler(e){ e.preventDefault(); const input = document.querySelector('#search-desktop') || document.querySelector('#search-mobile'); if (input) input.value=""; } -
test and verify that the changes still work by performing a search in both mobile and desktop views on the Projects and Projects-Check pages
Resources/Instructions
Tutorial on Chrome's Dev Tools to test for mobile views: https://developer.chrome.com/docs/devtools/device-mode
- Dominant language
- JavaScript
- Stars
- 364
- Forks
- 871
- Avg merge
- 4d 13h
- Merged PRs (30d)
- 13
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hackforla/website
-
Feature: Code Alerts good first issue P-Feature: Project Info and Page role: back end/devOps role: front end size: 0.25pt
Difficulty 1/5 Under an hour Newbie friendliness 90/100
hackforla/website#8825 · 1 comment ·
Maintainers usually reply within 1 day
-
Feature: Code Alerts good first issue P-Feature: Project Info and Page role: back end/devOps role: front end size: 0.25pt
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Feature: Code Alerts good first issue P-Feature: Project Info and Page role: back end/devOps role: front end size: 0.25pt
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
good first issue P-Feature: Project Info and Page P-Feature: Projects page Ready for Prioritization role: back end/devOps role: front end size: 0.25pt time sensitive
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
ER: [Toolkit Page]: Fix "undefined" message shown when filter selects no guide or resource cardsOpenComplexity: Large ER needs issue: large non-PR contribution P-Feature: Toolkit Ready for Prioritization role: front end size: 1pt
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hackforla/website#8819 · 2 comments ·
Maintainers usually reply within 1 day
All issues in hackforla/website
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 3 days
-
audit.md numbers Theming and Responsive Design differently in the headings and the score tablePossibly taken @pbakaus claimed this today. Openneeds triage
Difficulty 1/5 Under an hour Newbie friendliness 90/100
pbakaus/impeccable#979 ·
Maintainers usually reply within 1 day
-
area/web interface
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
mastodon/mastodon#40924 · 1 comment ·
Maintainers usually reply within 1 day
-
fireEvent.select does not wrap its automatic native focus in actPossibly taken @sergioperezcheco claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
bug user-priority/P2
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day