Resolve "Potentially unsafe external link" for Carbon Five in `_includes/about-page/about-card-sponsors.html`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- docker, html
- Domain
- security
Research direction
Open _includes/about-page/about-card-sponsors.html and find the Carbon Five link shown in the issue. Add the specified rel attribute, then use Docker to check /about in mobile, tablet, and desktop views and confirm the link still works and opens as expected. Done when the security attribute is present and those checks pass.
Written by the indexing model from the issue text.
Description
Prerequisite
- Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
- Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.
Overview
We need to fix a potentially unsafe external link by adding the attribute rel="noopener noreferrer". The problem and solution are similar to those detailed in the CodeQL alerts tracked in #5129; however, the instance addressed by this issue did not result in a CodeQL alert.
Action Items
- Open the file
_includes/about-page/about-card-sponsors.htmlin your IDE - Replace
<a href="https://www.carbonfive.com" target="_blank" alt="Carbon Five">
with
<a href="https://www.carbonfive.com" target="_blank" alt="Carbon Five" rel="noopener noreferrer">
- Using Docker, check the
/aboutpage and confirm that the page remains the same in mobile, tablet, and desktop views as on the current website. - Confirm that the Carbon Five link still works and opens as expected.
Merge Team
- When this issue is completed, check off the corresponding item in #5129
Resources/Instructions
- GitHub CodeQL documentation
- Webpage: https://www.hackforla.org/about/
- This issue is part of #5129
- Dominant language
- JavaScript
- Stars
- 364
- Forks
- 871
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 13
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hackforla/website
-
good first issue P-Feature: Project Info and Page ready for merge team role: back end/devOps role: front end size: 0.25pt
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
good first issue P-Feature: Project Info and Page ready for merge team role: back end/devOps role: front end size: 0.25pt
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
good first issue P-Feature: Project Info and Page ready for merge team role: back end/devOps role: front end size: 0.25pt
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
good first issue P-Feature: Project Info and Page ready for merge team role: back end/devOps role: front end size: 0.25pt
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
good first issue P-Feature: Project Info and Page ready for merge team role: back end/devOps role: front end size: 0.25pt
Difficulty 1/5 Under an hour Newbie friendliness 80/100
Maintainers usually reply within 1 day
All issues in hackforla/website
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
enhancement
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
holepunchto/hrpc-test#28 ·
-
good first issue
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
anoopcodehack/DevBoard#616 ·
Maintainers usually reply within 2 days
-
idnits3
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
ietf-tools/idnits#319 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 76/100
521xueweihan/HelloGitHub#3939 ·