The snapshot hook draws the selected view picker segment blank

Open
#405 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
swift
Domain
desktop

Research direction

Read Sources/SwitchboardApp/Snapshot.swift, especially Snapshot.cache around the location cited in the issue, and compare captures of the Inbox and Board views in light and dark mode. The issue suggests drawing the selected segment label or capturing with ScreenCaptureKit, then tuning the dark mode vibrancy recolor against a real screenshot. Done means the selected labels render and sidebar text brightness matches the real window; three open PRs also change this file.

Written by the indexing model from the issue text.

Description

priority: low

The SB_SNAPSHOT hook still draws the selected segment of the toolbar's view picker blank, and it draws dark-mode sidebar text dimmer than the app shows it.

What happens

#335 made Snapshot.cache draw scroll view contents, vibrancy, the selected row, and sheet dimming on top of cacheDisplay. Its description names two gaps it left, and captures of main at b3895e34 show both:

  • The selected segment ("Inbox 3" on the Inbox, "Board" on the Board) draws as an empty white pill.
  • In dark mode, sidebar rows draw dimmer and paler than in the real window, because the window server's vibrancy blend isn't public.

Why it matters

The README rewrite (#274) and every UI fix's before/after check rely on this hook. A blank selected segment makes every capture look broken at the spot a reader checks first.

Suggested fix

Draw the selected segment's label on top, the way cache already draws scroll view contents, or capture with ScreenCaptureKit when the app has Screen Recording permission. For dark mode, tune the vibrancy recolor against a real screenshot.

This is finding 16 of the #295 UI once-over. Open PRs #376, #382, and #383 change Snapshot.swift.

Dominant language
Swift
Stars
0
Forks
0
Avg merge
6h 15m
Merged PRs (30d)
308

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from haacked/switchboard

All issues in haacked/switchboard

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.