Test that unpause keeps the pause of a session being deleted

Open
#419 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
66/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
swift
Domain
testing

Research direction

Start with Sources/SwitchboardService/Service+Pause.swift and trace unpause, beingDeletedRefusal, and the removal job's Undo path. Find the existing tests for group resume and met --until conditions, then cover both while removal is in progress. Done when each test confirms the pause remains, no unpaused event is recorded, the resume message is retained, and Undo resumes the session; fix the guard if a test exposes a failure.

Written by the indexing model from the issue text.

Description

unpause in Sources/SwitchboardService/Service+Pause.swift refuses a session that is being deleted (beingDeletedRefusal) before it clears the pause. The check came in during the #325 merge in PR #345, and no test covers it.

Add tests for a group resume and a met --until condition while the removal job holds the session. Each should show:

  • the pause stays,
  • no unpaused event is recorded,
  • the resume message is not lost,
  • the session resumes after Undo.

If a test shows the guard doesn't hold, fix the code too.

Dominant language
Swift
Stars
0
Forks
0
Avg merge
6h 15m
Merged PRs (30d)
308

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from haacked/switchboard

All issues in haacked/switchboard

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.