View switching and history commands sit in the Session menu

Open
#400 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
swift

Research direction

Start with Sources/SwitchboardApp/App.swift, especially the Session command menu around lines 53–122 and the menu bar item around line 224. Review open PRs #376, #383, and #260 first because they also change App.swift; then check how SwiftUI defines the View and Go menus. Done when the listed view and navigation commands are in their requested menus, session actions remain in Session, and the quit label reads “Quit Switchboard”.

Written by the indexing model from the issue text.

Description

View switching and history commands live in the Session menu, mixed with actions on the selected session.

What happens

CommandMenu("Session") holds Show Inbox, Show Board, Show Issues, Filter by Org, Search, Next/Previous Session, Back, Forward, Show Recent Places, and the focus commands. Stop, Resume, Done, and Acknowledge are in the same menu. The menu bar item ends with "Quit" (App.swift:224), without the app's name.

Why it matters

Mac apps put view switching in the View menu and history in a Go menu (Finder, Xcode, Safari's History). A user looking for Back won't think to open a menu named Session. A menu bar item's quit command reads "Quit ".

Suggested fix

  • Move Show Inbox, Board, and Issues, and Filter by Org, to CommandGroup(after: .sidebar) in View.
  • Add a Go menu with Back, Forward, Recent Places, Next Needing You, and Next/Previous Session.
  • Keep the Session menu for actions on the selected session.
  • Rename the menu bar item's "Quit" to "Quit Switchboard".

This is finding 11 of the #295 UI once-over. Open PRs #376, #383, and #260 change App.swift, and #383 renames Filter by Org.

Dominant language
Swift
Stars
0
Forks
0
Avg merge
6h 15m
Merged PRs (30d)
308

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from haacked/switchboard

All issues in haacked/switchboard

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.