The sidebar search field is a button that can't take typing

Open
#398 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
swift

Research direction

Read Sources/SwitchboardApp/ContentView.swift lines 309–333 and inspect how the search sheet is opened. The suggested .searchable(text:placement: .sidebar) depends on BoardModel.sidebarGroups, which open PR #383 changes; PRs #375 and #382 also overlap in BoardModel.swift and ContentView.swift. Done means the sidebar has a field that accepts typing and is announced as a text field, while ⌘K still opens or focuses the intended search.

Written by the indexing model from the issue text.

Description

The sidebar's "Search Sessions" field is a button styled to look like a search field. You can't type into it, and VoiceOver reads it as a button.

What happens

ContentView.swift:309-333 adds a plain Button in .safeAreaInset(edge: .top) with a magnifying glass, "Search Sessions", "⌘K", and a quaternary rounded fill. A click opens the search sheet. The comment says it sits there because a sixth toolbar item would push New Session into the overflow menu.

Why it matters

A control that looks like a text field should take focus and typing. Someone who clicks it and starts typing loses the first keys while the sheet opens. VoiceOver users hear a button where sighted users see a field.

Suggested fix

Use .searchable(text:placement: .sidebar). It puts a real field at the top of the sidebar and doesn't take a toolbar slot. Typing filters the sidebar. Keep ⌘K for the ranked search sheet, or route ⌘K to focus the field.

This is finding 9 of the #295 UI once-over. The sidebar filter needs BoardModel.sidebarGroups, which open PR #383 changes. Open PRs #375 and #382 also change BoardModel.swift, and all three change ContentView.swift.

Dominant language
Swift
Stars
0
Forks
0
Avg merge
6h 15m
Merged PRs (30d)
308

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from haacked/switchboard

All issues in haacked/switchboard

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.