The toolbar crowds Back, Forward, and Recent Places into one capsule and merges the trailing buttons

Open
#396 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
52/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
swift
Domain
design, desktop

Research direction

Read Sources/SwitchboardApp/NavHistoryControls.swift and the .toolbar block in Sources/SwitchboardApp/ContentView.swift (lines 127 and 140–157), then compare the toolbar with the described captures. Check open PRs #375, #382, #383, and #260 before starting because they touch these files. Done means the history buttons and trailing actions have the separation described in the suggested fix, without changing the account item behavior from #339.

Written by the indexing model from the issue text.

Description

The toolbar crowds Back, Forward, and Recent Places into one small capsule, and it merges the Manager, account, Import, and New Session buttons into another.

What happens

  • NavHistoryControls puts the three buttons in one HStack(spacing: 2) inside one ToolbarItem (ContentView.swift:127). macOS draws them as one capsule, and the clock touches its edge.
  • ContentView.swift:140-157 gives the Manager star, the account menu, Import, and New Session one ToolbarItem each with no spacer, so macOS 26 draws them in one glass capsule.

Captures of main at 1024 and 1600 pt, in light and dark, show both. #339 already made the account item an icon only, which kept New Session out of the overflow menu.

Why it matters

Mail, Finder, and Xcode put Back and Forward in separate .navigation items with system spacing. The primary action, New Session, usually stands apart from secondary buttons. #364 item 1 reports the same crowding of the history controls.

Suggested fix

  • Make Back and Forward two ToolbarItem(placement: .navigation)s, and give Recent Places its own item.
  • Add a ToolbarSpacer so New Session stands alone, and group the Manager and account items apart from Import.

This is finding 6 of the #295 UI once-over. The account item's orange color is finding 14 (#403). Open PRs #375, #382, and #383 change the .toolbar block in ContentView.swift, and #260 changes NavHistoryControls.swift.

Dominant language
Swift
Stars
0
Forks
0
Avg merge
6h 15m
Merged PRs (30d)
308

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from haacked/switchboard

All issues in haacked/switchboard

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.