At 1024 pt the Board cuts the Approved column mid-card and hides Merging

Open
#393 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
swift
Domain
frontend

Research direction

Read Sources/SwitchboardApp/ContentView.swift around lines 598 and 661, then inspect BoardView and the open pull requests #382 and #383 for overlapping changes. Reproduce the layout at 1024 pt and compare the lane and state column widths. Done means Approved and Merging are reachable without cards appearing cut off at the supported window width.

Written by the indexing model from the issue text.

Description

At 1024 pt the Board still cuts the Approved column mid-card and leaves Merging off screen.

What happens

#358 made the state columns fit the window between 165 and 280 pt and turned the scroller on. The repo or group name still sits in a fixed 140 pt column on the left of every lane (ContentView.swift:598, :661). With five columns at the 165 pt minimum, the Board needs about 1,060 pt beside the sidebar, and a 1024 pt window leaves about 720. A capture of main at b3895e34 shows In progress, Waiting, and In review. Approved shows only its left edge and the "APPR" header, and Merging is hidden. The capture can't draw scrollers, so it can't show whether the scroller appears. #358's own captures say it does.

Why it matters

A column cut mid-card reads as a layout bug, and the minimum window width is a size the app supports. The cards a user most wants to act on (Approved, Merging) are the ones off screen.

Suggested fix

Put each lane's name above its row as a section header instead of in a fixed column. That gives the state columns the 140 pt back. If they still don't fit, let the columns go below 165 pt at narrow widths, or hide the sidebar on the Board below about 1200 pt.

This is finding 3 of the #295 UI once-over. Open PRs #382 and #383 change BoardView in ContentView.swift.

Dominant language
Swift
Stars
0
Forks
0
Avg merge
6h 15m
Merged PRs (30d)
308

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from haacked/switchboard

All issues in haacked/switchboard

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.