Inbox items raised by a wait show unrelated transcript steps in Details

Open
#371 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
swift

Research direction

Start by locating the Inbox item Details view and the code that assembles "Latest steps" and wait summaries; the issue does not name files or tests. Trace how a wait's target, timestamps, note, and current state reach the card, then identify its available actions and title layout. Done means wait details and actions are shown first, transcript steps are collapsed below, and the spacing and title truncation are corrected.

Written by the indexing model from the issue text.

Description

When a wait raises an Inbox item, the item's Details show the session's latest transcript steps under "Latest steps". Those steps often have nothing to do with the wait, so the Details don't explain the summary above them.

Example: a session held a review wait on PostHog/posthog#135173 (who: PostHog/clickhouse, note "Asked ClickHouse and team-feature-flags in Slack"). After a day, the wait raised an Inbox item: "A review from PostHog/clickhouse on #135173: still open after 1 d." The card says "This item didn't come from the conversation." But "Latest steps" showed the session's recent work on CI for a different PR, #136787: a Semgrep fix and a push. Nothing in Details was about the review on #135173.

For an item that a wait raised, Details should show the wait:

  • what it waits for, such as the PR, the reviewer, the CI run or the deploy
  • when it was set and when it rechecks
  • its note
  • the current state of what it waits on, for a review wait, the PR's review decision and pending review requests

It should also offer actions that fit a wait, such as clearing it, rechecking now, or opening the PR. The latest transcript steps can still be there, but collapsed and below the wait, since they may be about something else.

Two smaller things on the same card:

  • "still open after 1 d" puts a space between the number and the unit. It should read "1d" or "1 day".
  • The title cuts off at "still open aft…" even though the line has plenty of room.

Related: #369, where a session switched to a follow-up branch and kept a wait on its first PR, so the header showed one PR and the summary another.

Dominant language
Swift
Stars
0
Forks
0
Avg merge
6h 15m
Merged PRs (30d)
308

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from haacked/switchboard

All issues in haacked/switchboard

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.