Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Please add the offer system

Open
  • Is something wrong?
#849 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp, mongodb
Domain
backend

Research direction

Read the catalog model around Product fields VendorId, Sku, StockQuantity and Price, then trace how IPricingService uses Product. Compare ProductAttributeCombination, OrderItem, Vendor, InventoryJournal and ShoppingCartItem to understand the proposed design. This issue asks whether shared-catalog offers are in scope and explicitly does not commit to implementation; done means maintainers decide whether one-product-one-vendor is a deliberate boundary.

Written by the indexing model from the issue text.

Description

Shared catalog: can multiple vendors sell the same product?

I evaluated GrandNode2 for a marketplace project and read through the catalog domain model. One question I couldn't settle from the code, so I'd rather ask than assume.

Observation

Product carries the seller, price and stock on a single document — VendorId (line 82), Sku (147), StockQuantity (335), Price (431) — and IPricingService takes Product as the price-bearing entity throughout. One catalog record therefore belongs to one vendor.

That supports a marketplace where each vendor owns their own listings. It doesn't support a shared catalog, where several vendors compete on the same record and the storefront selects a winning offer — Amazon's buy box, Google Shopping. Under the current model, two vendors selling the same title produce two products, two URLs and two sets of reviews.

What already exists

Several pieces are in place. ProductAttributeCombination already models SKU, price and stock as a unit hanging off a product; it simply doesn't carry a VendorId. OrderItem already has VendorId and Commission. Vendor already has the rating aggregates a ranking would need. InventoryJournal is already polymorphic over ObjectType.

The gap appears to be one entity — an Offer holding vendor, product, price, stock and status — plus a selection service, and an OfferId on ShoppingCartItem so the cart remembers which vendor the customer chose.

On compatibility

This could be additive. If an offer service synthesises an implicit offer from the product when no explicit ones exist, an installation with zero offer rows behaves exactly as it does today: no migration, no setting change, no rewrite.

Question

Is a shared-catalog marketplace in scope for GrandNode2, or is one-product-one-vendor a deliberate boundary? Either answer is useful — if it's out of scope, I'll close this.

Happy to expand on any of the above. I can't commit to implementing it, so please treat this as a design question rather than a proposal of work.

Dominant language
C#
Stars
1.3k
Forks
549
Avg merge
8h 14m
Merged PRs (30d)
53

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from grandnode/grandnode2

All issues in grandnode/grandnode2

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.