The imports list on a phone hides how each import went
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 65/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- frontend, internationalization
Research direction
Start in plugins/importer/frontend/ImportsScreen.tsx at phoneFields in useListView, and in importFields.tsx where the table columns use formatNumber. Add a counts field that is listed only in phoneFields, then add the _n plural messages in alphone-importer.pot, es-ES.po and the compiled es-ES.json. Done when imports.test.tsx renders the list at phone width and shows the committed and ready/importing lines, and the Spanish plural forms are filled in.
Written by the indexing model from the issue text.
Description
What happens
Below 640 pixels wide, the imports list at /import switches from the table to the DataViews list layout. ImportsScreen sets phoneFields to the state and the start date, so each row shows only the file name, the state badge and the date. The four counts the table shows (rows, imported, skipped and failed) are gone. On a phone you cannot tell how an import went without opening it.
Adding the count fields to phoneFields does not fix this. The list layout hides each field's label from sight, so the row would show four bare numbers with nothing to say which is which.
What should happen
On a phone, each row shows one short counts line between the state and the date:
- a committed import: "2 of 6 imported, 3 skipped, 1 failed"
- a ready or importing import: "6 rows", because its other three counts stay at zero until the commit finishes
The table on a wide screen does not change. A new field in importFields renders the line, and only phoneFields lists it. The numbers go through formatNumber, like the count columns.
The words live in the alphone-importer text domain. Each part is its own _n message keyed on its own count. In Spanish the word changes with the number ("1 omitida", "3 omitidas"), even where the English singular and plural read the same. One more translatable message, such as %(imported)s, %(skipped)s, %(failed)s, puts the three parts together so a language can change the order. These are the first plural messages in the importer, and the Spanish catalogue fills all three forms of each. A test renders the list at phone width and checks the line in both cases.
Where
plugins/importer/frontend/importFields.tsx, a new field for the counts lineplugins/importer/frontend/ImportsScreen.tsx,phoneFieldsinuseListViewplugins/importer/languages/alphone-importer.potandes-ES.po, and the compiledplugins/importer/frontend/languages/es-ES.jsonplugins/importer/frontend/test/imports.test.tsx, a test at phone width
- Dominant language
- Go
- Stars
- 287
- Forks
- 64
- Avg merge
- 13h 24m
- Merged PRs (30d)
- 60
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from gopherium/AlphOne
-
good first issue help wanted javascript
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
All issues in gopherium/AlphOne
Similar issues
-
[BUG] deploy.restart_policy without condition drops the restart policyPossibly taken @akshat-lakhera claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
docker/compose#14383 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
AvengeMedia/dank-greeter#39 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
dokku/dokku-datastore#367 ·
Maintainers usually reply within 1 day
-
[Bug]: ap gateway image build cannot find local policies on WindowsPossibly taken @Jayzilva claimed this today. OpenAspect/Configuration Severity/Major
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
wso2/api-platform#3912 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days