Remove conditionals related to google-api-core versions, once we no longer support older versions.

Open
#18,657 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
30/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
api

Research direction

The issue names no files. Start by searching the GAPIC-generated Python client code for checks on the google-api-core version, such as feature-detection branches for versions 2.35.0 and 2.42.0. Maintainers should first confirm the support-drop timeline, since the change should wait until then. Done means those version-gated branches are removed while the supported versions still work and the tests pass.

Written by the indexing model from the issue text.

Description

type: cleanup
Determine this is the right repository
  • I determined this is the correct repository in which to report this bug.
Summary of the issue

There are conditional checks OR situations in GAPIC generated code that depend on features that are not available when

  • google-api-core < 2.42.0.
  • google-api-core < 2.35.0

Once we drop support, those conditionals should be updated to remove tech debt.

API client name and version

No response

Reproduction steps: code
Reproduction steps: supporting files
Reproduction steps: actual results
Reproduction steps: expected results
OS & version + platform

No response

Python environment

No response

Python dependencies

No response

Additional context

No response

Dominant language
Python
Stars
5.4k
Forks
1.8k
Avg merge
2d 7h
Merged PRs (30d)
173

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from googleapis/google-cloud-python

All issues in googleapis/google-cloud-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.