ci: enable --strict flag in presubmit twine_check

Open Beginner friendly
#18,339 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
76/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
python, shell
Domain
build-system, ci-cd

Research direction

After #18211 populates long_description_content_type in the package setup.py files, open ci/run_single_test.sh and locate the presubmit twine_check command. Enable --strict for the dist/* check, then verify the presubmit check completes successfully with the stricter validation.

Written by the indexing model from the issue text.

Description

Overview

The presubmit twine_check step in ci/run_single_test.sh currently runs twine check dist/* without --strict to avoid false-positive failures caused by missing long_description_content_type metadata in existing setup.py files (see #18211).

Goal

Once long_description_content_type="text/x-rst" is populated across package setup.py files via #18211, re-enable the --strict flag in ci/run_single_test.sh:

twine check --strict dist/*
Dominant language
Python
Stars
5.4k
Forks
1.8k
Avg merge
1d 17h
Merged PRs (30d)
93

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from googleapis/google-cloud-python

All issues in googleapis/google-cloud-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.