Make admin1 required in Australia and Turkey
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 52/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- localization
Research direction
Review the country format files for Australia and Turkey, then compare them with the Malaysia, Argentina, and Ireland cases discussed in the issue. Update the requiredness of admin1 for Australia and Turkey while leaving the comparison cases unchanged; done means those two countries require admin1 and the other reviewed formats retain their current behavior.
Written by the indexing model from the issue text.
Description
I believe that admin level 1 should be required for the following countries, even though they are currently optional in the format files.
Australia. See https://auspost.com.au/sending/check-sending-guidelines/addressing-guidelines for the postal guidelines: "The last line should contain the place name or post office of delivery, state or territory abbreviation and postcode. This line should be printed in capitals without punctuation or underlining, with the postcode put last.".
I have also checked every other country in the data set where admin1 is supported but optional. I think it's just the following three, and they look correct to me.
Malaysia. The examples on https://www.pos.com.my/business/business-mail-solutions/products/standard-mail.html include some with the province written and some without it.
Ireland. See https://correctaddress.anpost.ie/pages/Search.aspx, where the county should be shown on an envelope "where required". That implies it is not always required. As a concrete example where that is true, addresses in Dublin frequently leave off the "Co. Dublin" when formatting the address.
- Dominant language
- C++
- Stars
- 629
- Forks
- 109
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from google/libaddressinput
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
google/libaddressinput#255 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
google/libaddressinput#245 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 64/100
google/libaddressinput#254 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 52/100
google/libaddressinput#250 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
google/libaddressinput#249 ·
All issues in google/libaddressinput
Similar issues
-
area:runtime good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
WATonomous/wato_f1tenth#39 ·
-
[APP BUG]: Sorting by name after searching can bring up irrelevant resultsPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
shadps4-emu/shadps4-qtlauncher#465 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
duckdb/duckdb-excel#104 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
lxqt/lxqt-powermanagement#495 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Qiskit/qiskit-aer#2466 ·