Revoke request uses GET instead of POST
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- objective-c
- Domain
- authentication
Research direction
Start at -disconnectWithCompletion: and follow its call to startFetchURL:, where the NSMutableURLRequest is created. Compare the revocation request with the linked Google documentation and RFC 7009 section 2.1; done means the request uses POST and carries the token in a form-encoded body.
Written by the indexing model from the issue text.
Description
-disconnectWithCompletion: sends the revocation request over GET, because startFetchURL: builds an NSMutableURLRequest without setting HTTPMethod.
Our documentation (mobile) says to use a POST request; and RFC 7009 section 2.1 specifies a POST carrying the token in a form-encoded body.
- Dominant language
- Objective-C
- Stars
- 751
- Forks
- 282
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 11
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from google/GoogleSignIn-iOS
-
enhancement triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
google/GoogleSignIn-iOS#620 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
google/GoogleSignIn-iOS#440 · 4 comments · 2 reactions ·
-
enhancement triage
Difficulty 4/5 3-5 days Newbie friendliness 48/100
google/GoogleSignIn-iOS#611 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
google/GoogleSignIn-iOS#607 ·
-
enhancement triage
Difficulty 4/5 3-5 days Newbie friendliness 52/100
google/GoogleSignIn-iOS#602 ·
All issues in google/GoogleSignIn-iOS
Similar issues
-
Suzhou subway logo OpenIcons Metro Public Transport
Difficulty 1/5 Under an hour Newbie friendliness 75/100
organicmaps/organicmaps#13617 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
objective-see/LuLu#925 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
noah-nuebling/mac-mouse-fix#2054 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
obsproject/obs-studio#13918 ·