Add App Check support for macOS
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 52/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- objective-c
- Domain
- authentication, desktop
Research direction
Start in GoogleSignIn/Sources/GIDSignIn.m and trace the App Check code guarded by TARGET_OS_IOS && !TARGET_OS_MACCATALYST, including the GIDSignIn.sharedInstance.configure path. Compare the existing platform conditions and determine the macOS-compatible entry point. Done means macOS apps can enable App Check through GIDSignIn.sharedInstance.configure or an equivalent method.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem you're having? Please describe.
App Check is currently not supported on macOS. The GIDSignIn.sharedInstance.configure method, which is required to enable App Check, is only available on iOS.
Looking at the source code, App Check related code is wrapped in #if TARGET_OS_IOS && !TARGET_OS_MACCATALYST, which confirms that macOS is intentionally excluded from the current implementation.
Describe the solution you'd like
Please add App Check support for macOS so that GIDSignIn.sharedInstance.configure (or an equivalent method) can be called on macOS as well.
Describe alternatives you've considered
No alternatives have been found. macOS apps are currently forced to run without App Check.
Additional context
Relevant source file: GoogleSignIn/Sources/GIDSignIn.m
#if TARGET_OS_IOS && !TARGET_OS_MACCATALYST
#import <AppCheckCore/GACAppCheckToken.h>
#import "GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.h"
// ...
#endif // TARGET_OS_IOS && !TARGET_OS_MACCATALYST
- Dominant language
- Objective-C
- Stars
- 751
- Forks
- 282
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from google/GoogleSignIn-iOS
-
enhancement triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
google/GoogleSignIn-iOS#621 ·
-
enhancement triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
google/GoogleSignIn-iOS#620 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
google/GoogleSignIn-iOS#440 · 4 comments · 2 reactions ·
-
enhancement triage
Difficulty 4/5 3-5 days Newbie friendliness 48/100
google/GoogleSignIn-iOS#611 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
google/GoogleSignIn-iOS#607 ·
All issues in google/GoogleSignIn-iOS
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
noah-nuebling/mac-mouse-fix#2054 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
obsproject/obs-studio#13918 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HigherOrderCO/Bend#842 · 2 comments ·