Add test coverage for the userinfo profile-fetch fallback
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- objective-c
- Domain
- authentication, mobile, testing
Research direction
Start with GIDSignIn.m and the existing testDisconnectNoCallback_tokenWithReservedCharacters test for setup and URL-encoding behavior. Add coverage for an ID token without profile claims, verify the /oauth2/v3/userinfo URL and encoded access_token, and confirm the response maps correctly onto GIDProfileData.
Written by the indexing model from the issue text.
Description
The userinfo request in GIDSignIn.m does not have any test coverage (this is the fallback that fetches basic profile data if the ID token doesn't carry it).
Suggested changes:
- Set up a sign in whose ID token lacks profile claims, so the profile-fetch fallback runs
- Assert the userinfo request URL: scheme, host, path /oauth2/v3/userinfo, and the access_token query parameter
- Include a token containing URL-reserved characters (&, =, #). (testDisconnectNoCallback_tokenWithReservedCharacters does this to test recent changes that ensure those characters are encoded correctly)
- Assert the returned data maps correctly onto GIDProfileData
- Dominant language
- Objective-C
- Stars
- 751
- Forks
- 282
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from google/GoogleSignIn-iOS
-
enhancement triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
google/GoogleSignIn-iOS#621 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
google/GoogleSignIn-iOS#440 · 4 comments · 2 reactions ·
-
enhancement triage
Difficulty 4/5 3-5 days Newbie friendliness 48/100
google/GoogleSignIn-iOS#611 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
google/GoogleSignIn-iOS#607 ·
-
enhancement triage
Difficulty 4/5 3-5 days Newbie friendliness 52/100
google/GoogleSignIn-iOS#602 ·
All issues in google/GoogleSignIn-iOS
Similar issues
-
clawsweeper:source-repro impact:other issue-rating: 🦞 diamond lobster P2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
openclaw/openclaw-facetime#40 · 2 comments · 1 reaction ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
noah-nuebling/mac-mouse-fix#2054 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
obsproject/obs-studio#13918 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
SwiftOldDriver/iOS-Weekly#5439 · 1 comment ·