One-PR stack: submit reports success, but merge says the stack was not submitted
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 76/100
Research direction
Start in cmd/submit.go by reading syncStack and its caller, then compare the remote-stack check in cmd/merge.go. Reproduce the one-PR flow with the commands in the issue; done means submit accurately reports the missing remote stack and merge gives a usable result or next command without telling the user to repeat a successful submission.
Written by the indexing model from the issue text.
Description
Summary
A local stack can contain one branch and one pull request. gh stack submit reports success for this stack:
✓ Pushed and synced 1 branches
However, GitHub does not create a remote stack object. A remote stack requires at least two pull requests.
gh stack merge then rejects the local stack:
✗ this stack has not been submitted to GitHub yet; run `gh stack submit` first
A second gh stack submit does not fix the problem. It reports success again.
Reproduction
- Create a branch from the trunk branch.
- Commit a change on the new branch.
- Initialize a local stack that contains only the new branch.
- Run
gh stack submitand create the pull request. - Run
gh stack submitagain. - Run
gh stack merge --squash.
Example output:
$ gh stack submit
Checking stack state...
Pushing to origin...
PR #30 for close-clinkr-cli-entry-point is up to date
✓ Pushed and synced 1 branches
$ gh stack sync
✓ Fetched latest main from origin
✓ Trunk main is already up to date
Pushing 1 branch to origin...
✓ Pushed 1 branches
Syncing PRs ...
✓ PR #30 (close-clinkr-cli-entry-point) — Open
✓ Branches synced
Stacked on main (69c442c)
$ gh stack merge --squash
✗ this stack has not been submitted to GitHub yet; run `gh stack submit` first
The pull request exists and is open. In this reproduction, GitHub also reported the pull request as mergeable and clean.
Expected behavior
The commands should not give conflicting results.
gh stack submit should state that it published a regular pull request but did not create a remote stack object. Alternatively, it should explain that a remote stack requires at least two pull requests.
gh stack merge should handle a local stack with one pull request. It can merge the pull request directly, or it can show an actionable command such as gh pr merge.
Actual behavior
gh stack submit reports that it pushed and synchronized the one-branch stack. It exits successfully.
gh stack merge reports that the same stack was not submitted. It tells the user to repeat the command that already reported success.
Source context
The behavior is also present on the current github/gh-stack main branch at commit ab00aa4a3f2dddc51aa65849c68b391a1b079311.
In cmd/submit.go, syncStack returns false when the stack has fewer than two pull requests:
// The API requires at least 2 PRs to form a stack.
if len(prNumbers) < 2 {
return false
}
The caller does not use this result:
if stacksAvailable {
syncStack(cfg, client, s)
clearPendingModifyState(cfg, gitDir)
}
The command then prints the success message:
cfg.Successf("Pushed and synced %d branches", len(s.ActiveBranches()))
In cmd/merge.go, the merge command requires a remote stack ID or number:
if s.ID == "" && s.Number == 0 {
cfg.Errorf("this stack has not been submitted to GitHub yet; run `gh stack submit` first")
return nil, ErrNotInStack
}
Thus, the submit command knows that it did not create a remote stack object. However, it discards that result and reports success.
Environment
gh stack version 0.1.0
Darwin 25.6.0 arm64
Deviations: none.
- Dominant language
- Go
- Stars
- 1.5k
- Forks
- 73
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-stack
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
feature request topic: cli - general
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
feature request topic: auto-merge
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug topic: docs
Difficulty 1/5 Under an hour Newbie friendliness 68/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
NVIDIA/gpu-operator#2955 ·
-
agentic-workflows
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
kovidgoyal/kitty#10516 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
cisagov/vulnrichment#337 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100